Enable test that already fixed #70065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-reflection-emit Issue DetailsApparently the ModuleBuilder.GetType does not work with ignore case with certain unicode chars on Unix was fixed by Add support for invariant casing in PAL. Tested on Ubuntu, no failure Closes #18231
|
buyaa-n
commented
Jun 1, 2022
| @@ -10,7 +10,7 @@ public class ModuleBuilderDefineType | |||
| { | |||
| public static IEnumerable<object[]> TestData() | |||
| { | |||
| foreach (string name in new string[] { "TestName", "testname", "class", "\uD800\uDC00", "a\0b\0c" }) | |||
There was a problem hiding this comment.
Turns out it was failing on mono only for "a\0b\0c" case and @GrabYourPitchforks suggested to remove it as it is not valid scenario to test
|
The failure is known issue it doesn't have any code change anyways, merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the ModuleBuilder.GetType does not work with ignore case with certain unicode chars on Unix was fixed by Add support for invariant casing in PAL.
Tested on Ubuntu
Closes #18231