Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mono] Fix C4018 warnings round II #70783

Merged
merged 6 commits into from
Jun 21, 2022

Conversation

fanyang-mono
Copy link
Member

Second portion of fixing C4018 warnings on Mono runtime x86/x64 Windows build, aligning with SDL requirements (#66154).

Copy link
Member

@lambdageek lambdageek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. please also update the definition of upd_locator_t in hot_reload.c - it needs to stay in sync with locator_t

src/mono/mono/metadata/debug-mono-ppdb.c Show resolved Hide resolved
@fanyang-mono
Copy link
Member Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fanyang-mono
Copy link
Member Author

Failures on CI are not related to this PR. They were seen on rolling build as well.

@fanyang-mono fanyang-mono merged commit 18d7e39 into dotnet:main Jun 21, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants