Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IPAddress equality comparison in MsQuicListener #70979

Merged
merged 5 commits into from
Jun 21, 2022
Merged

Fix IPAddress equality comparison in MsQuicListener #70979

merged 5 commits into from
Jun 21, 2022

Conversation

rzikm
Copy link
Member

@rzikm rzikm commented Jun 20, 2022

No description provided.

@ghost ghost assigned rzikm Jun 20, 2022
@ghost
Copy link

ghost commented Jun 20, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: rzikm
Assignees: -
Labels:

area-System.Net
Milestone: -

JamesNK
JamesNK requested changes Jun 20, 2022
View reviewed changes
Copy link
Member

@JamesNK JamesNK left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test. This is subtle behavior and it's possible to accidentally regress in the future if there isn't an automated test to verify.

@ghost ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Jun 20, 2022
@ghost ghost removed the needs-author-action An issue or pull request that requires more info or actions from the author. label Jun 20, 2022
@rzikm rzikm requested a review from JamesNK June 20, 2022 08:22
@rzikm rzikm merged commit ff57575 into dotnet:main Jun 21, 2022
@karelz karelz added this to the 7.0.0 milestone Jul 19, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonfirsov antonfirsov antonfirsov left review comments

@Wraith2 Wraith2 Wraith2 left review comments

@JamesNK JamesNK JamesNK approved these changes

@stephentoub stephentoub stephentoub approved these changes

@ManickaP ManickaP ManickaP approved these changes

Assignees

@rzikm rzikm

Labels
area-System.Net
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@rzikm @JamesNK @stephentoub @antonfirsov @ManickaP @Wraith2 @karelz