Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update design docs to reflect our new marshaller design from partner feedback #71017

Merged
merged 5 commits into from
Jun 23, 2022

Conversation

jkoritzinsky
Copy link
Member

The interop team has been working on new designs for our source-generated marshallers. Now that we're starting implementation in the runtime of these new marshallers, let's make sure to follow our "write it down" culture so we have a record of why we did what we did for our future selves.

@jkoritzinsky jkoritzinsky added area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature labels Jun 20, 2022
@ghost ghost assigned jkoritzinsky Jun 20, 2022
@ghost
Copy link

ghost commented Jun 20, 2022

Tagging subscribers to this area: @dotnet/interop-contrib
See info in area-owners.md if you want to be subscribed.

Issue Details

The interop team has been working on new designs for our source-generated marshallers. Now that we're starting implementation in the runtime of these new marshallers, let's make sure to follow our "write it down" culture so we have a record of why we did what we did for our future selves.

Author: jkoritzinsky
Assignees: -
Labels:

area-System.Runtime.InteropServices, source-generator

Milestone: -

Co-authored-by: Aaron Robinson <arobins@microsoft.com>
Copy link
Member

@AaronRobinsonMSFT AaronRobinsonMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure @elinor-fung signs off on this too.

@jkoritzinsky jkoritzinsky requested a review from elinor-fung June 22, 2022 23:49
…ngV2.md

Co-authored-by: Elinor Fung <elfung@microsoft.com>
@jkoritzinsky jkoritzinsky merged commit 9e8c7a8 into dotnet:main Jun 23, 2022
@jkoritzinsky jkoritzinsky deleted the updated-design-docs branch June 23, 2022 03:17
@ghost ghost locked as resolved and limited conversation to collaborators Jul 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime.InteropServices source-generator Indicates an issue with a source generator feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants