Improve and simplify MakeTmpArgNode

[SingleAccretion]

Use the ABI info stored in the call arg instead of bespoke logic and do not address-expose temps which will be passed by value.

We're expecting diffs:

1. GC info: GT_LCL_VAR_ADDRs are typed TYP_I_IMPL as opposed to TYP_BYREF.
2. Improvements from the lack of address-exposure, especially on ARM (regressions from CSE/etc).
3. One small Unix x64 regression because the old code would retype an on-stack arg to long/int even if the "base type" of it was double/float, and FP movs are slightly larger than GPR ones.

Also fixes a potential LA-specific bug where we could retype struct { float, int } as TYP_LONG.

Diffs.

[ghost]

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Use the ABI info stored in the call arg instead of bespoke logic and do not address-expose temps which will be passed by value.

We're expecting diffs:

1. GC info: GT_LCL_VAR_ADDRs are typed TYP_I_IMPL as opposed to TYP_BYREF.
2. Improvements from the lack of address-exposure, especially on ARM (regressions from CSE/etc).
3. One small Unix x64 regression because the old code would retype an on-stack arg to long/int even if the "base type" of it was double/float, and FP movs are slightly larger than GPR ones.

Also fixes a potential LA-specific bug where we could retype struct { float, int } as TYP_LONG.

Author:	SingleAccretion
Assignees:	-
Labels:	area-CodeGen-coreclr
Milestone:	-

[SingleAccretion]

@dotnet/jit-contrib

[jakobbotsch]

/azp run runtime-coreclr superpmi-replay

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).