Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][aot] Enabling System.Text.RegularExpressions.Tests #71126

Merged
merged 4 commits into from
Jun 24, 2022
Merged

[wasm][aot] Enabling System.Text.RegularExpressions.Tests #71126

merged 4 commits into from
Jun 24, 2022

Conversation

ilonatommy
Copy link
Member

Fixes #61756.
Unit tests from the same lib are still failing, leaving disabled.

@ilonatommy ilonatommy added arch-wasm WebAssembly architecture area-Codegen-AOT-mono labels Jun 22, 2022
@ilonatommy ilonatommy added this to the 7.0.0 milestone Jun 22, 2022
@ilonatommy ilonatommy requested a review from radical June 22, 2022 11:29
@ilonatommy ilonatommy self-assigned this Jun 22, 2022
@ghost
Copy link

ghost commented Jun 22, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #61756.
Unit tests from the same lib are still failing, leaving disabled.

Author: ilonatommy
Assignees: ilonatommy
Labels:

arch-wasm, area-Codegen-AOT-mono
Milestone: 7.0.0

@ilonatommy
Copy link
Member Author

ilonatommy commented Jun 22, 2022 •
edited
Loading

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented Jun 22, 2022

The AOT build is running out of memory on helix (linux, and windows). Add these tests to

runtime/src/libraries/tests.proj

Lines 28 to 30 in a57f519

<ItemGroup Condition="'$(TargetOS)' == 'Browser'">
<!-- https://github.com/dotnet/runtime/issues/65356 - OOM while linking -->
<HighAOTResourceRequiringProject Include="$(MSBuildThisFileDirectory)System.Text.Json\tests\System.Text.Json.SourceGeneration.Tests\System.Text.Json.SourceGeneration.Roslyn3.11.Tests.csproj" />
which are for running such tests.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ilonatommy ilonatommy mentioned this pull request Jun 23, 2022
Closed
@ilonatommy ilonatommy closed this Jun 23, 2022
@radical
Copy link
Member

radical commented Jun 23, 2022

Add

runtime/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/Microsoft.Extensions.Logging.Generators.Roslyn3.11.Tests.csproj

Lines 8 to 10 in 3205533

<ItemGroup>
<HighAotMemoryUsageAssembly Include="Microsoft.CodeAnalysis.CSharp.dll" />
</ItemGroup>
to the test project. This is the one that's causing the out of memory issue.

@ilonatommy ilonatommy reopened this Jun 24, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical radical merged commit 7e213b3 into dotnet:main Jun 24, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@radical radical radical approved these changes

Assignees

@ilonatommy ilonatommy

Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

[wasm][aot] RangeError: Maximum call stack size exceeded in System.Text.RegularExpressions.Tests
3 participants
@ilonatommy @radical @stephentoub