Add test coverage for generic type substitution with byreflike generics #71276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test coverage also found some interesting behavior (issue TBD) in the following scenario: Given a `<byreflike T>` (aka a `T` that can be a byreflike type), we allow passing this to a `<U>` generic parameter (where `U` does not allow byref-like types). We do correctly throw when instantiating the generic with a byreflike type though, so we don't end up in a bad state. I've marked this test with an ActiveIssue attribute pending feedback on whether or not this is a bug.
ghost
assigned 
|
Test assets for #65112. |
AaronRobinsonMSFT
approved these changes
Jun 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test coverage also found some interesting behavior (issue TBD) in the following scenario:
Given a
<byreflike T>(aka aTthat can be a byreflike type), we allow passing this to a<U>generic parameter (whereUdoes not allow byref-like types).We do correctly throw when instantiating the generic with a byreflike type though, so we don't end up in a bad state.
I've marked this test with an ActiveIssue attribute pending feedback on whether or not this is a bug.