Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Array.Resize in data storages #71302

Merged
merged 3 commits into from
Jun 27, 2022
Merged

Use Array.Resize in data storages #71302

merged 3 commits into from
Jun 27, 2022

Conversation

petarpetrovt
Copy link
Contributor

@petarpetrovt petarpetrovt commented Jun 26, 2022

The new code is a bit shorter and performs better if SetCapacity is called multiple times with the same value (doesn't perform an allocation and copy if same size).

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 26, 2022
@ghost
Copy link

ghost commented Jun 26, 2022

Tagging subscribers to this area: @roji, @ajcvickers
See info in area-owners.md if you want to be subscribed.

Issue Details

The new code is a bit shorter and performs better if SetCapacity is called multiple times with the same value (dosen't perform an allocation and copy if same size).

Author: petarpetrovt
Assignees: -
Labels:

area-System.Data

Milestone: -

@roji roji merged commit 198b8bf into dotnet:main Jun 27, 2022
@roji
Copy link
Member

roji commented Jun 27, 2022

Thanks @petarpetrovt!

@ghost ghost locked as resolved and limited conversation to collaborators Jul 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Data community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants