Make sure we emit diagnostics for "unsupported" marshalling for downlevel platforms #71342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…evel platforms Separate out the "no marshalling info" error factory from the "unsupported" marshalling factory so we still get the same diagnostics on downlevel platforms where we use the forwarder as our fallback. Fixes dotnet#71315
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsSeparate out the "no marshalling info" error factory from the "unsupported" marshalling factory so we still get the same diagnostics on downlevel platforms where we use the forwarder as our fallback. Fixes #71315
|
AaronRobinsonMSFT
approved these changes
Jun 27, 2022
...braries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/Diagnostics.cs
Outdated
Show resolved
Hide resolved
…rtGenerator.UnitTests/Diagnostics.cs
|
Failure is NativeAOT timeout |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate out the "no marshalling info" error factory from the "unsupported" marshalling factory so we still get the same diagnostics on downlevel platforms where we use the forwarder as our fallback.
Fixes #71315