Rewire polymorphism metadata to the contract model #71346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
area-System.Text.Json
new-api-needs-documentation
labels
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis |
eiriktsarpalis
commented
Jun 27, 2022
eiriktsarpalis
commented
Jun 27, 2022
krwq
reviewed
Jun 27, 2022
krwq
reviewed
Jun 27, 2022
...es/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Read.HandleMetadata.cs
Show resolved
Hide resolved
krwq
reviewed
Jun 27, 2022
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonDerivedType.cs
Show resolved
Hide resolved
krwq
reviewed
Jun 27, 2022
...ries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonPolymorphismOptions.cs
Show resolved
Hide resolved
krwq
reviewed
Jun 28, 2022
...ries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonPolymorphismOptions.cs
Show resolved
Hide resolved
krwq
reviewed
Jun 28, 2022
...ries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonPolymorphismOptions.cs
Show resolved
Hide resolved
krwq
reviewed
Jun 28, 2022
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfo.cs
Show resolved
Hide resolved
krwq
reviewed
Jun 28, 2022
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonTypeInfo.cs
Show resolved
Hide resolved
krwq
reviewed
Jun 28, 2022
...ies/System.Text.Json/src/System/Text/Json/Serialization/Metadata/SourceGenJsonTypeInfoOfT.cs
Show resolved
Hide resolved
krwq
reviewed
Jun 28, 2022
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/Metadata/JsonDerivedType.cs
Show resolved
Hide resolved
eiriktsarpalis
commented
Jun 28, 2022
| } | ||
| public enum JsonUnknownTypeHandling | ||
| { | ||
| JsonElement = 0, | ||
| JsonNode = 1, | ||
| } | ||
| public partial class JsonPolymorphicTypeConfiguration : System.Collections.Generic.ICollection<(System.Type DerivedType, object? TypeDiscriminator)>, System.Collections.Generic.IEnumerable<(System.Type DerivedType, object? TypeDiscriminator)>, System.Collections.IEnumerable |
There was a problem hiding this comment.
First change made in the implementation of this PR: Remove provisional JsonPolymorphicTypeConfiguration
eiriktsarpalis
commented
Jun 28, 2022
| public System.Action<System.Text.Json.Utf8JsonWriter, TCollection>? SerializeHandler { get { throw null; } init { } } | ||
| } | ||
| public readonly partial struct JsonDerivedType |
There was a problem hiding this comment.
Added JsonDerivedType struct
eiriktsarpalis
commented
Jun 28, 2022
| @@ -1161,15 +1135,24 @@ public sealed partial class JsonParameterInfoValues | |||
| public System.Type ParameterType { get { throw null; } init { } } | |||
| public int Position { get { throw null; } init { } } | |||
| } | |||
| public partial class JsonPolymorphismOptions | |||
There was a problem hiding this comment.
Add JsonPolymorphismOptions
eiriktsarpalis
commented
Jun 28, 2022
| [System.Diagnostics.CodeAnalysis.RequiresUnreferencedCode("JSON serialization and deserialization might require types that cannot be statically analyzed and might need runtime code generation. Use generic overload or System.Text.Json source generation for native AOT applications.")] | ||
| [System.Diagnostics.CodeAnalysis.RequiresDynamicCode("JSON serialization and deserialization might require types that cannot be statically analyzed and might need runtime code generation. Use generic overload or System.Text.Json source generation for native AOT applications.")] | ||
| public System.Text.Json.JsonSerializerOptions Options { get { throw null; } } | ||
| public System.Text.Json.Serialization.Metadata.JsonPolymorphismOptions? PolymorphismOptions { get { throw null; } set { } } |
There was a problem hiding this comment.
Add JsonPolymorphismOptions property to JsonTypeInfo
eiriktsarpalis
commented
Jun 28, 2022
| @@ -356,19 +356,12 @@ public sealed partial class JsonSerializerOptions | |||
| public System.Text.Json.JsonNamingPolicy? PropertyNamingPolicy { get { throw null; } set { } } | |||
| public System.Text.Json.JsonCommentHandling ReadCommentHandling { get { throw null; } set { } } | |||
| public System.Text.Json.Serialization.ReferenceHandler? ReferenceHandler { get { throw null; } set { } } | |||
| public System.Collections.Generic.IList<System.Text.Json.Serialization.JsonPolymorphicTypeConfiguration> PolymorphicTypeConfigurations { get { throw null; } } | |||
There was a problem hiding this comment.
Remove provisional PolymorphicTypeConfigurations property from JsonSerializerOptions.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #63747 by rewiring its metadata APIs to the newly merged contract model (#70435).
Fixes #63747.