[wasm] Add Vector128.OnesComplement SIMD intrinsic #71384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add wasm specific implementation of Vector128.OnesComplement method.
Example compilation output. Managed:
static Vector128<double> SimdTest3(Vector128<double> input)
{
return Vector128.OnesComplement(input);
}
IR:
BB3: ; preds = %BB2
%cast_to_4_x_i32 = bitcast <2 x double> %simd_vtype to <4 x i32>
%wasm_not = xor <4 x i32> %cast_to_4_x_i32, <i32 -1, i32 -1, i32 -1, i32 -1>
%cast_back = bitcast <4 x i32> %wasm_not to <2 x double>
br label %BB4
wasm:
(func Wasm_Console_V8_CJS_Sample_Test_SimdTest3_System_Runtime_Intrinsics_Vector128_1_double(param $0 i32, $1 i32, $2 i32))
local $3 i32
local $4 i32
local $5 v128
local $6 v128
0x00cf955a: global.get $__stack_pointer
0x00cf955c: local.set $3
0x00cf955e: i32.const 16
0x00cf9560: local.set $4
0x00cf9562: local.get $3
0x00cf9564: local.get $4
0x00cf9566: i32.sub
0x00cf9567: drop
0x00cf9568: local.get $1
0x00cf956a: v128.load align:4 [SIMD]
0x00cf956e: local.set $5
0x00cf9570: local.get $5
0x00cf9572: v128.not [SIMD]
0x00cf9574: local.set $6
0x00cf9576: local.get $6
0x00cf9578: drop
0x00cf9579: local.get $0
0x00cf957b: local.get $6
0x00cf957d: v128.store [SIMD]
0x00cf9581: return
radekdoulik
requested review from
vargaz,
lambdageek and
SamMonoRT
as code owners
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vargaz
approved these changes
Jun 28, 2022
vargaz
reviewed
Jun 28, 2022
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsAdd wasm specific implementation of Example compilation output. Managed: IR: wasm - Debug configuration: wasm - Release configuration:
|
|
The failing WBTs are known issue, being worked on in #70704 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add wasm specific implementation of
Vector128.OnesComplementmethod.Example compilation output. Managed:
IR:
wasm - Debug configuration:
wasm - Release configuration: