Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] test case for broken .locals init #71387

Closed
wants to merge 2 commits into from
Closed

[wasm] test case for broken .locals init #71387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f98b9c8
test case for broken .locals init
pavelsavara Jun 28, 2022
4524c6c
more
pavelsavara Jun 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/libraries/Common/src/Interop/Browser/Interop.Runtime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ internal static partial class Runtime
[MethodImplAttribute(MethodImplOptions.InternalCall)]
internal static extern void CancelPromiseRef(IntPtr promiseJSHandle, out int exceptionalResult, out string result);

[MethodImplAttribute(MethodImplOptions.InternalCall)]
internal static extern void DoNothing(out int exceptionalResult);

// / <summary>
// / Execute the provided string in the JavaScript context
// / </summary>
Expand Down
8 changes: 8 additions & 0 deletions ...ntime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Runtime.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

using System.Diagnostics.CodeAnalysis;
using System.Reflection;
using System.Runtime.CompilerServices;
using System.Threading.Tasks;

namespace System.Runtime.InteropServices.JavaScript
Expand All @@ -12,6 +13,13 @@ public static partial class Runtime
private const string TaskGetResultName = "get_Result";
private static readonly MethodInfo _taskGetResultMethodInfo = typeof(Task<>).GetMethod(TaskGetResultName)!;

[MethodImpl(MethodImplOptions.AggressiveInlining)]
public static int DoNothing()
{
Interop.Runtime.DoNothing(out int exception);
return exception;
}

/// <summary>
/// Execute the provided string in the JavaScript context
/// </summary>
Expand Down
10 changes: 0 additions & 10 deletions ...pServices.JavaScript/tests/System.Private.Runtime.InteropServices.JavaScript.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,6 @@
</PropertyGroup>
<ItemGroup>
<Compile Include="System\Runtime\InteropServices\JavaScript\JavaScriptTests.cs" />
<Compile Include="System\Runtime\InteropServices\JavaScript\DataViewTests.cs" />
<Compile Include="System\Runtime\InteropServices\JavaScript\MemoryTests.cs" />
<Compile Include="System\Runtime\InteropServices\JavaScript\TypedArrayTests.cs" />
<Compile Include="System\Runtime\InteropServices\JavaScript\ArrayTests.cs" />
<Compile Include="System\Runtime\InteropServices\JavaScript\MarshalTests.cs" />
<Compile Include="System\Runtime\InteropServices\JavaScript\DelegateTests.cs" />
<Compile Include="System\Runtime\InteropServices\JavaScript\HelperMarshal.cs" />
<Compile Include="System\Runtime\InteropServices\JavaScript\Http\HttpRequestMessageTest.cs" />
<Compile Include="System\Runtime\InteropServices\JavaScript\ParallelTests.cs" />
<Compile Include="System\Runtime\InteropServices\JavaScript\TimerTests.cs" />
</ItemGroup>

<ItemGroup>
Expand Down
173 changes: 0 additions & 173 deletions ....InteropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/ArrayTests.cs
View file
Open in desktop

This file was deleted.

134 changes: 0 additions & 134 deletions ...teropServices.JavaScript/tests/System/Runtime/InteropServices/JavaScript/DataViewTests.cs
View file
Open in desktop

This file was deleted.

Loading