Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce System.Runtime.TieredPGO knob #71438

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Jun 29, 2022

Related SDK PR: dotnet/sdk#26350

The idea is to introduce a configuration switch similar to TieredCompilation to expose a config switch for TieredPGO. It's done because many of our first/third parties are interested in trying Dynamic PGO and currently it's only possible with DOTNET_TieredPGO=1 env. variable defined in the execution process.

With this PR and the related SDK change customers will be able to turn it on (it's off by default) via MSBUILD or JSON config just like TieredCompilation, e.g.:

<TieredPGO>true</TieredPGO>

@EgorBo
Copy link
Member Author

EgorBo commented Jun 30, 2022

Not sure who to ask for review, @AndyAyersMS ?

Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but maybe somebody on the runtime side should sign off?

cc @mangod9

@EgorBo EgorBo merged commit f5a78eb into dotnet:main Jul 1, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants