Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete the zero-offset field sequence map #71455

Merged
merged 13 commits into from
Jul 8, 2022
Merged

Delete the zero-offset field sequence map #71455

merged 13 commits into from
Jul 8, 2022

Commits on Jul 2, 2022

  1. Delete the unused GTF_ICON_FIELD_OFF

    @SingleAccretion
    SingleAccretion committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    85a0ab4 View commit details
    Browse the repository at this point in the history

  2. Do not try to find "IND(struct ARR_ADDR)" handle 

    Leftover from GT_INDEX.
    @SingleAccretion
    SingleAccretion committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    86f0e3a View commit details
    Browse the repository at this point in the history

  3. Delete the zero-offset field sequence map 

    For statics at a zero offset, preserve the "CNS_INT 0" node instead.
    @SingleAccretion
    SingleAccretion committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    4822795 View commit details
    Browse the repository at this point in the history

  4. Make all field sequences singletons

    @SingleAccretion
    SingleAccretion committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    2e9e7b7 View commit details
    Browse the repository at this point in the history

  5. Print struct field offsets in the sequence

    @SingleAccretion
    SingleAccretion committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    3a9095e View commit details
    Browse the repository at this point in the history

  6. Improve address mode marking to handle COMMAs 

    This avoids regressing cases where we now have new CSE
opportunities for statics with static init helper calls.
    @SingleAccretion
    SingleAccretion committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    5c87956 View commit details
    Browse the repository at this point in the history

  7. Delete NotAField 

    Replace with using "nullptr" directly.

Note that "nullptr" can mean both an absense of a field
sequence and an "implicit" sequence of struct fields.
    @SingleAccretion
    SingleAccretion committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    f2c866e View commit details
    Browse the repository at this point in the history

  8. Refactor the field sequence store 

    Now that we don't need the map to be a set, we can apply some optimizations.
    @SingleAccretion
    SingleAccretion committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    2159def View commit details
    Browse the repository at this point in the history

  9. FieldSeqNode -> FieldSeq

    @SingleAccretion
    SingleAccretion committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    f5341c2 View commit details
    Browse the repository at this point in the history

  10. Turn asserts into "noway_assert"s 

    We don't expect empty sequences: they are either coming from
the "IsFieldAddr" code path, which disallows these, or from
the boxed static code path, where we should always have them.
    @SingleAccretion
    SingleAccretion committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    c760d47 View commit details
    Browse the repository at this point in the history

  11. Fix formatting

    @SingleAccretion
    SingleAccretion committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    319febe View commit details
    Browse the repository at this point in the history

  12. Take down SPMI

    @SingleAccretion
    SingleAccretion committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    bdbaf25 View commit details
    Browse the repository at this point in the history

  13. Resurrect SPMI to work around a CG2 bug

    @SingleAccretion
    SingleAccretion committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    0cad61a View commit details
    Browse the repository at this point in the history