Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] InterpToNativeGenerator: use invariant culture when generating C #71460

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

radical
Copy link
Member

@radical radical commented Jun 29, 2022

.. functions.

Wasm native build in Turkish culture would fail with:

In file included from C:\Program Files\dotnet\packs\Microsoft.NETCore.App.Runtime.Mono.browser-wasm\7.0.0-preview.6.22312.1\runtimes\browser-wasm\native\src\driver.c:37: (TaskId:242)
C:\Users\v-danche\myblazor\obj\Debug\net7.0\wasm\for-publish\wasm_m2n_invoke.g.h:13:18: error: implicit declaration of function 'mono_wasm_interp_method_args_get_─▒arg' is invalid in C99 [-Werror,-Wimplicit-function-declaration] (TaskId:242)
        int res = func (mono_wasm_interp_method_args_get_─▒arg (margs, 0)); (TaskId:242)
                        ^ (TaskId:242)
C:\Users\v-danche\myblazor\obj\Debug\net7.0\wasm\for-publish\wasm_m2n_invoke.g.h:23:18: error: implicit declaration of function 'mono_wasm_interp_method_args_get_─▒arg' is invalid in C99 [-Werror,-Wimplicit-function-declaration] (TaskId:242)
        int res = func (mono_wasm_interp_method_args_get_─▒arg (margs, 0), mono_wasm_interp_method_args_get_─▒arg (margs, 1), mono_wasm_interp_method_args_get_─▒arg (margs, 2)); (TaskId:242)
                        ^ (TaskId:242)

This is odd character in the function name is 'I' converted (in Turkish) to lower case, which is not 'i'.

Fixes #71149

@radical radical requested review from radekdoulik, maraf and lewing June 29, 2022 20:38
@radical radical added the arch-wasm WebAssembly architecture label Jun 29, 2022
@ghost ghost assigned radical Jun 29, 2022
@ghost
Copy link

ghost commented Jun 29, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

.. functions.

Wasm native build in Turkish culture would fail with:

In file included from C:\Program Files\dotnet\packs\Microsoft.NETCore.App.Runtime.Mono.browser-wasm\7.0.0-preview.6.22312.1\runtimes\browser-wasm\native\src\driver.c:37: (TaskId:242)
C:\Users\v-danche\myblazor\obj\Debug\net7.0\wasm\for-publish\wasm_m2n_invoke.g.h:13:18: error: implicit declaration of function 'mono_wasm_interp_method_args_get_─▒arg' is invalid in C99 [-Werror,-Wimplicit-function-declaration] (TaskId:242)
        int res = func (mono_wasm_interp_method_args_get_─▒arg (margs, 0)); (TaskId:242)
                        ^ (TaskId:242)
C:\Users\v-danche\myblazor\obj\Debug\net7.0\wasm\for-publish\wasm_m2n_invoke.g.h:23:18: error: implicit declaration of function 'mono_wasm_interp_method_args_get_─▒arg' is invalid in C99 [-Werror,-Wimplicit-function-declaration] (TaskId:242)
        int res = func (mono_wasm_interp_method_args_get_─▒arg (margs, 0), mono_wasm_interp_method_args_get_─▒arg (margs, 1), mono_wasm_interp_method_args_get_─▒arg (margs, 2)); (TaskId:242)
                        ^ (TaskId:242)

This is odd character in the function name is 'I' converted (in Turkish) to lower case, which is not 'i'.

Fixes #71149

Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono

Milestone: -

@radical
Copy link
Member Author

radical commented Jun 29, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jun 29, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jun 30, 2022

Coreclr failure is #71475 .
WBT failure is #70675, unrelated to this PR.

@radical radical merged commit 14dac22 into dotnet:main Jun 30, 2022
@radical radical deleted the fix-pinvoke-turk branch June 30, 2022 06:15
@ghost ghost locked as resolved and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Development

Successfully merging this pull request may close these issues.

With .NET7 preview 6 SDK installed on Turkish OS, error happen when dotnet publish with AOT enable.
2 participants