Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] JSImport, JSExport and related API types for JavaScript interop #71500

Merged
merged 37 commits into from
Jul 7, 2022
Merged

[wasm] JSImport, JSExport and related API types for JavaScript interop #71500

merged 37 commits into from
Jul 7, 2022

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Jun 30, 2022 •
edited
Loading

  • adds approved API for [JSImport], [JSExport] and related types with empty implementations
    • the implementation is in followup PR 66304
  • initial draft of xmldoc
  • I omitted JSType.None from the approved API, which is my copy&paste mistake from time when it was still enum.

Fixes #70133

@pavelsavara
- approved API
ce862bf 
- xmldoc
@pavelsavara pavelsavara added this to the 7.0.0 milestone Jun 30, 2022
@pavelsavara pavelsavara self-assigned this Jun 30, 2022
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jun 30, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • adds approved API for [JSImport], [JSExport] and related types with empty implementations
    • the implementation is in followup PR 66304
  • initial draft of xmldoc

Fixes #70133

Author: pavelsavara
Assignees: pavelsavara
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 7.0.0

@pavelsavara pavelsavara marked this pull request as ready for review July 1, 2022 04:35
@pavelsavara pavelsavara requested a review from marek-safar as a code owner July 1, 2022 04:35
maraf
maraf reviewed Jul 1, 2022
View reviewed changes
...stem.Runtime.InteropServices.JavaScript/src/System.Runtime.InteropServices.JavaScript.csproj Show resolved Hide resolved
...stem.Runtime.InteropServices.JavaScript/src/System.Runtime.InteropServices.JavaScript.csproj Outdated Show resolved Hide resolved
...m.Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSHost.cs Outdated Show resolved Hide resolved
...ropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSMarshalAsAttribute.cs Outdated Show resolved Hide resolved
....InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSMarshalerType.cs Outdated Show resolved Hide resolved
...Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSObject.cs Outdated Show resolved Hide resolved
...Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSObject.cs Outdated Show resolved Hide resolved
...Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSObject.cs Outdated Show resolved Hide resolved
...Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSObject.cs Outdated Show resolved Hide resolved
...Runtime.InteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/JSObject.cs Outdated Show resolved Hide resolved
pavelsavara and others added 8 commits July 1, 2022 10:12
@pavelsavara @maraf
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
3ec1f11 
…stem.Runtime.InteropServices.JavaScript.csproj

Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
c543eae 
…stem/Runtime/InteropServices/JavaScript/JSHost.cs

Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
27bcc71 
…stem/Runtime/InteropServices/JavaScript/JSMarshalAsAttribute.cs

Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
55bf0a9 
…stem/Runtime/InteropServices/JavaScript/JSMarshalerType.cs

Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
c863663 
…stem/Runtime/InteropServices/JavaScript/JSObject.cs

Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
145f4dd 
…stem/Runtime/InteropServices/JavaScript/JSObject.cs

Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
19be286 
…stem/Runtime/InteropServices/JavaScript/JSObject.cs

Co-authored-by: Marek Fišera <mara@neptuo.com>
@pavelsavara @maraf
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
ae03f07 
…stem/Runtime/InteropServices/JavaScript/JSObject.cs

Co-authored-by: Marek Fišera <mara@neptuo.com>
pavelsavara and others added 25 commits July 5, 2022 14:12
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
6a221d0 
…stem/Runtime/InteropServices/JavaScript/JSExportAttribute.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
602ccb6 
…stem/Runtime/InteropServices/JavaScript/JSFunctionBinding.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
d26d97c 
…stem/Runtime/InteropServices/JavaScript/JSFunctionBinding.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
3baf815 
…stem/Runtime/InteropServices/JavaScript/JSFunctionBinding.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
b817256 
…stem/Runtime/InteropServices/JavaScript/JSFunctionBinding.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
a18482b 
…stem/Runtime/InteropServices/JavaScript/JSHost.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
8661f71 
…stem/Runtime/InteropServices/JavaScript/JSHost.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
7c2e990 
…stem/Runtime/InteropServices/JavaScript/JSHost.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
a98299d 
…stem/Runtime/InteropServices/JavaScript/JSHost.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
8891d3e 
…stem/Runtime/InteropServices/JavaScript/JSImportAttribute.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
689b2fa 
…stem/Runtime/InteropServices/JavaScript/JSImportAttribute.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
279aa29 
…stem/Runtime/InteropServices/JavaScript/JSImportAttribute.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
0277fd0 
…stem/Runtime/InteropServices/JavaScript/JSMarshalAsAttribute.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
ee1ccf9 
…stem/Runtime/InteropServices/JavaScript/JSMarshalerArgument.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
5417f32 
…stem/Runtime/InteropServices/JavaScript/JSMarshalerArgument.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
70899cc 
…stem/Runtime/InteropServices/JavaScript/JSObject.References.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
a20985e 
…stem/Runtime/InteropServices/JavaScript/JSObject.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
43cf19d 
…stem/Runtime/InteropServices/JavaScript/JSObject.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
28ef236 
…stem/Runtime/InteropServices/JavaScript/JSType.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
8058db2 
…stem/Runtime/InteropServices/JavaScript/JSType.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
10b72ea 
…stem/Runtime/InteropServices/JavaScript/JSType.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara @kg
Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…
43c129a 
…stem/Runtime/InteropServices/JavaScript/JSType.cs

Co-authored-by: Katelyn Gadd <kg@luminance.org>
@pavelsavara
Merge branch 'main' into wasm_jsimport_jsexport_api
4683d01
@pavelsavara
feedback
5fe129a
@pavelsavara
feedback
60410e1
@pavelsavara
Copy link
Member Author

Timeout on WasmTestOnBrowser-subtlecrypto-System.Security.Cryptography.Tests/console is unrelated.

@pavelsavara pavelsavara merged commit 1206b82 into dotnet:main Jul 7, 2022
@pavelsavara pavelsavara deleted the wasm_jsimport_jsexport_api branch July 14, 2022 20:46
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@maraf maraf maraf approved these changes

@kg kg kg left review comments

@radical radical Awaiting requested review from radical

@lambdageek lambdageek Awaiting requested review from lambdageek

@marek-safar marek-safar Awaiting requested review from marek-safar

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript new-api-needs-documentation
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

[API Proposal]: JavaScript interop with [JSImport] and [JSExport] attributes and Roslyn
3 participants
@pavelsavara @kg @maraf