Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove implicit fallback to reflection-based serialization #71746

Merged
merged 11 commits into from
Jul 7, 2022
Merged

Remove implicit fallback to reflection-based serialization #71746

merged 11 commits into from
Jul 7, 2022

Conversation

eiriktsarpalis
Copy link
Member

Makes the following changes:

@eiriktsarpalis
Remove implicit fallback to reflection-based serialization. Fix dotne…
708b8cc 
…t#71714

Include JsonSerializerContext in JsonSerializerOptions copy constructor. Fix dotnet#71716

Move reflection-based converter resolution out of JsonSerializerOptions. Fix dotnet#68878
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost ghost assigned eiriktsarpalis Jul 7, 2022
@eiriktsarpalis eiriktsarpalis requested a review from krwq July 7, 2022 01:32
@ghost
Copy link

ghost commented Jul 7, 2022

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

Issue Details

Makes the following changes:

Author: eiriktsarpalis
Assignees: -
Labels:

area-System.Text.Json, new-api-needs-documentation
Milestone: -

@eiriktsarpalis eiriktsarpalis added this to the 7.0.0 milestone Jul 7, 2022
@eiriktsarpalis eiriktsarpalis requested a review from krwq July 7, 2022 20:09
@eiriktsarpalis @krwq
Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat…
ed6c70c 
…ion/JsonSerializerOptions.Converters.cs

Co-authored-by: Krzysztof Wicher <mordotymoja@gmail.com>
@eiriktsarpalis eiriktsarpalis merged commit 8e0a132 into dotnet:main Jul 7, 2022
@eiriktsarpalis eiriktsarpalis deleted the jsonserializer-breaking-change branch July 7, 2022 23:23
@radical radical mentioned this pull request Jul 8, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub left review comments

@krwq krwq krwq approved these changes

Assignees

@eiriktsarpalis eiriktsarpalis

Labels
area-System.Text.Json new-api-needs-documentation
Projects
None yet
Milestone
7.0.0
3 participants
@eiriktsarpalis @krwq @stephentoub