[QUIC] API QuicConnection #71783

ManickaP · 2022-07-07T20:57:28Z

Fixes #68902
Contributes to #69675

~~This PR is based on #71579 so it shows more changes that it actually contains.~~

dotnet-issue-labeler · 2022-07-07T20:57:36Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2022-07-07T20:57:47Z

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #68902
Contributes to #69675

This PR is based on #71579 so it shows more changes that it actually contains.

Author:	ManickaP
Assignees:	-
Labels:	`new-api-needs-documentation`, `area-System.Net.Quic`
Milestone:	-

ManickaP · 2022-07-10T20:31:08Z

This is fairly stable now, ready for review. Still letting it in draft due to unapproved API.
@CarnaViire @wfurt @rzikm if you could give it a look.

Also note that stream will be soon in PR as well.

src/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs

wfurt · 2022-07-12T15:42:07Z

src/libraries/System.Net.Quic/src/System/Net/Quic/Internal/MsQuicHelpers.cs

+
+    internal static unsafe QuicAddr ToQuicAddr(this IPEndPoint iPEndPoint)
+    {
+        // TODO: is the layout same for SocketAddress.Buffer and QuicAddr on all platforms?


it should AFAIK. It would be nice to have some assert about it. It differs among platforms but MsQUIC now uses native layout e.g. same as SocketAddress.

wfurt · 2022-07-12T15:47:55Z

src/libraries/System.Net.Quic/src/System/Net/Quic/Interop/MsQuicConfiguration.cs

+                authenticationOptions.ClientCertificates ?? new X509CertificateCollection(),
+                null,
+                Array.Empty<string>());
+            if (selectedCertificate.HasPrivateKey())


It would be nice to throw or at least log. I know this is what we we in SslStream for historical reasons but the failures when we silently ignore given certificate are annoying IMHO.
(this could be separate work)

ManickaP · 2022-07-12T19:59:08Z

This is update based on the last version of API from #68902 (comment)
Main changes:

behavior of DisposeAsync (automatically will close with DefaultCloseErrorCode)
removed required from the options and replaced by explicit validation

@CarnaViire @wfurt @rzikm please give it look

rzikm

LGTM, modulo comments.

src/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs

src/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnectionOptions.cs

src/libraries/System.Net.Quic/src/System/Net/Quic/QuicDefaults.cs

ManickaP · 2022-07-13T07:21:48Z

Failure is #71890, it's been closed in the meantime.

ManickaP · 2022-07-13T15:40:06Z

/backport to release/7.0-preview7

github-actions · 2022-07-13T15:40:22Z

Started backporting to release/7.0-preview7: https://github.com/dotnet/runtime/actions/runs/2664595774

github-actions · 2022-07-13T15:42:29Z

@ManickaP backporting to release/7.0-preview7 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Listener comment; PreviewFeature attribute
Applying: Feedback
Applying: QuicConnection new API including compilable implementation
error: sha1 information is lacking or useless (src/libraries/System.Net.Quic/src/System/Net/Quic/QuicListener.cs).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0003 QuicConnection new API including compilable implementation
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

* Listener comment; PreviewFeature attribute * Feedback * QuicConnection new API including compilable implementation * Fixed logging * Fixed S.N.Quic and S.N.Http tests * Options now correspond to the issue * Feedback * Comments, PreviewFeature attribute and RemoteCertificate disposal. * Preview feature attribute is assembly wide * Some typos * Fixed test with certificate * Default values as constants * Event handlers split into methods called via switch expression. * Some more comments * Unified unsafe usage * Fixed some more tests * Cleaned up some exceptions and resource strings. * Feedback * Latest greatest API proposal. * Fixed Http solution * Feedback

ManickaP · 2022-07-13T16:42:22Z

@JamesNK this will need your reaction as well. Note that the options classes were changed in the last API review and we removed the required keyword. If you hit any issues with this PR, let me know.

…72031) (#72106) * [QUIC] API QuicConnection (#71783) * Listener comment; PreviewFeature attribute * Feedback * QuicConnection new API including compilable implementation * Fixed logging * Fixed S.N.Quic and S.N.Http tests * Options now correspond to the issue * Feedback * Comments, PreviewFeature attribute and RemoteCertificate disposal. * Preview feature attribute is assembly wide * Some typos * Fixed test with certificate * Default values as constants * Event handlers split into methods called via switch expression. * Some more comments * Unified unsafe usage * Fixed some more tests * Cleaned up some exceptions and resource strings. * Feedback * Latest greatest API proposal. * Fixed Http solution * Feedback * [QUIC] API QuicStream (#71969) * Quic stream API surface * Fixed test compilation * Fixed http test compilation * HttpLoopbackConnection Dispose -> DisposeAsync * QuicStream implementation * Fixed some tests * Fixed all QUIC and HTTP tests * Fixed exception type for stream closed by connection close * Feedback * Fixed WebSocket.Client test build * Feedback, test fixes * Fixed build on framework and windows * Fixed winhandler test * Swap variable based on order in defining class * Post merge fixes * Feedback and build * Reverted connection state to pass around abort error code * Fixed exception type. * [QUIC] System.Net.Quic API made public (#72031) * System.Net.Quic removed from ASP transport package and made part of SDK ref * Removed manual references to System.Net.Quic.csproj

dotnet-issue-labeler bot added area-System.Net.Quic new-api-needs-documentation labels Jul 7, 2022

ghost assigned ManickaP Jul 7, 2022

ManickaP mentioned this pull request Jul 8, 2022

[QUIC] API QuicListener #71579

Merged

ManickaP force-pushed the mapichov/quic-connection branch 4 times, most recently from 88ad8f3 to e02c32c Compare July 8, 2022 18:36

ManickaP added 17 commits July 10, 2022 22:24

Listener comment; PreviewFeature attribute

051f36d

Feedback

43a4f28

QuicConnection new API including compilable implementation

ac2f047

Fixed logging

cec4e10

Fixed S.N.Quic and S.N.Http tests

a299200

Options now correspond to the issue

5ae441b

Feedback

86c885f

Comments, PreviewFeature attribute and RemoteCertificate disposal.

55b9248

Preview feature attribute is assembly wide

cb9d5ae

Some typos

16b757b

Fixed test with certificate

90410f0

Default values as constants

1ddcb1c

Event handlers split into methods called via switch expression.

af833a8

Some more comments

00c903b

Unified unsafe usage

9144f0f

Fixed some more tests

e50dd37

Cleaned up some exceptions and resource strings.

b480845

ManickaP force-pushed the mapichov/quic-connection branch from 189b9f5 to b480845 Compare July 10, 2022 20:25

CarnaViire reviewed Jul 11, 2022

View reviewed changes

src/libraries/System.Net.Quic/src/System/Net/Quic/QuicConnection.cs Outdated Show resolved Hide resolved

wfurt mentioned this pull request Jul 11, 2022

add CertificateChainPolicy to ssl options #71961

Merged

Feedback

b3cb553

This was referenced Jul 11, 2022

[QUIC] API QuicStream #71969

Merged

System.Net.Quic.Functional.Tests crash on coreclr/windows/x64 #71995

Closed

[QUIC] fixes failing assert #72022

Merged

wfurt reviewed Jul 12, 2022

View reviewed changes

ManickaP mentioned this pull request Jul 12, 2022

[QUIC] QuicConnection API follow up #72027

Closed

2 tasks

ManickaP added 2 commits July 12, 2022 18:34

Merge branch 'main' into mapichov/quic-connection

ba9d34e

Latest greatest API proposal.

1644dab

ManickaP marked this pull request as ready for review July 12, 2022 19:57

ManickaP added 2 commits July 12, 2022 22:33

Fixed Http solution

52ea7b9

Merge branch 'main' into mapichov/quic-connection

73c1ddd

rzikm approved these changes Jul 12, 2022

View reviewed changes

Feedback

8f19332

ManickaP merged commit d434c4a into dotnet:main Jul 13, 2022

ManickaP deleted the mapichov/quic-connection branch July 13, 2022 07:22

ManickaP mentioned this pull request Jul 13, 2022

[QUIC] API QuicConnection (#71783), QuicStream (#71969), QUIC public (#72031) #72106

Merged

ManickaP mentioned this pull request Jul 14, 2022

QUIC: Should not need finalization on MsQuicStream/Connection/Listener #55103

Closed

karelz added this to the 7.0.0 milestone Jul 19, 2022

ghost locked as resolved and limited conversation to collaborators Aug 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[QUIC] API QuicConnection #71783

[QUIC] API QuicConnection #71783

ManickaP commented Jul 7, 2022 •

edited

Loading

dotnet-issue-labeler bot commented Jul 7, 2022

ghost commented Jul 7, 2022

ManickaP commented Jul 10, 2022

wfurt Jul 12, 2022

ManickaP Jul 12, 2022

wfurt Jul 12, 2022

ManickaP Jul 12, 2022

ManickaP commented Jul 12, 2022

rzikm left a comment

ManickaP commented Jul 13, 2022

ManickaP commented Jul 13, 2022

github-actions bot commented Jul 13, 2022

github-actions bot commented Jul 13, 2022

ManickaP commented Jul 13, 2022

[QUIC] API QuicConnection #71783

[QUIC] API QuicConnection #71783

Conversation

ManickaP commented Jul 7, 2022 • edited Loading

dotnet-issue-labeler bot commented Jul 7, 2022

ghost commented Jul 7, 2022

ManickaP commented Jul 10, 2022

wfurt Jul 12, 2022

Choose a reason for hiding this comment

ManickaP Jul 12, 2022

Choose a reason for hiding this comment

wfurt Jul 12, 2022

Choose a reason for hiding this comment

ManickaP Jul 12, 2022

Choose a reason for hiding this comment

ManickaP commented Jul 12, 2022

rzikm left a comment

Choose a reason for hiding this comment

ManickaP commented Jul 13, 2022

ManickaP commented Jul 13, 2022

github-actions bot commented Jul 13, 2022

github-actions bot commented Jul 13, 2022

ManickaP commented Jul 13, 2022

ManickaP commented Jul 7, 2022 •

edited

Loading