Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][aot] Avoid making the 'this' variable volatile. #71799

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented Jul 8, 2022

This is only needed in non-llvmonly mode for computing stack traces in gshared methods.

@vargaz vargaz removed the request for review from SamMonoRT July 8, 2022 00:42
@ghost ghost assigned vargaz Jul 8, 2022
@vargaz
Copy link
Contributor Author

vargaz commented Jul 8, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lewing
Copy link
Member

lewing commented Jul 11, 2022

/azp run runtime

@lewing
Copy link
Member

lewing commented Jul 11, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This is only needed in non-llvmonly mode for computing stack traces in gshared methods.
@vargaz vargaz force-pushed the wasm-no-this-volatile branch from 022b87a to 0456082 Compare July 13, 2022 15:40
@vargaz
Copy link
Contributor Author

vargaz commented Jul 13, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vargaz vargaz merged commit 45432c5 into dotnet:main Jul 14, 2022
@vargaz vargaz deleted the wasm-no-this-volatile branch July 14, 2022 05:57
@ghost ghost locked as resolved and limited conversation to collaborators Aug 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants