Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not consider single-reg bitcasts multi-reg nodes #72020

Merged
merged 3 commits into from
Jul 18, 2022

Conversation

SingleAccretion
Copy link
Contributor

@SingleAccretion SingleAccretion commented Jul 12, 2022

Fixes #71831.

No diffs.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 12, 2022
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 12, 2022
@ghost
Copy link

ghost commented Jul 12, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

The method is currently used to mean both "a node that can define multiple registers", and "a node that does define multiple registers", which means that lowering must query the number of registers explicitly if it wants to know whether the given local store is from a multi-reg source.

A better solution would be to make IsMultiRegNode mean only one thing (likely the "does" interpretation), this, however, requires some work to make sure all places that need updating are updated.

Fixes #71831.

Author: SingleAccretion
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

@SingleAccretion SingleAccretion changed the title Work around the double meaning of IsMultiRegNode Do not consider single-reg bitcasts multi-reg nodes Jul 13, 2022
@SingleAccretion SingleAccretion marked this pull request as ready for review July 14, 2022 10:34
@SingleAccretion
Copy link
Contributor Author

coreclr Pri0 Runtime Tests Run windows arm64 checked failed with an empty log, will presume unrelated.

@dotnet/jit-contrib

@jakobbotsch jakobbotsch merged commit 4cbe6f9 into dotnet:main Jul 18, 2022
@SingleAccretion SingleAccretion deleted the MultiReg-BitCasts branch July 21, 2022 13:57
@ghost ghost locked as resolved and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IsMultiRegNode on ARM assumes all BITCASTs are multi-reg
3 participants