[RateLimiting] Fix test race with timer #72118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Tagging subscribers to this area: @mangod9 Issue DetailsFixes #72060
|
halter73
approved these changes
Jul 20, 2022
| @@ -13,7 +13,7 @@ namespace System.Threading.RateLimiting.Tests | |||
| { | |||
| internal static class Utils | |||
| { | |||
| internal static Func<Task> StopTimerAndGetTimerFunc<T>(PartitionedRateLimiter<T> limiter) | |||
| internal static async Task<Func<Task>> StopTimerAndGetTimerFunc<T>(PartitionedRateLimiter<T> limiter) | |||
There was a problem hiding this comment.
This type signature! 😆 It looks like this should fix the bug, but can we just add a private/internal ctor to DefaultPartitionedRateLimiter that doesn't start the timer?
There was a problem hiding this comment.
Tried out the private ctor approach. Definitely removes the possibility of test races now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72060