[release/7.0-preview7] Implement HttpProtocolException for HTTP/3 #72210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #72095 to release/7.0-preview7 /cc @rzikm Customer ImpactTestingRiskIMPORTANT: If this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.
|
carlossanlop
added
the
Servicing-consider
carlossanlop
approved these changes
Jul 14, 2022
carlossanlop
added
Servicing-approved
|
Approved via email by Tactics. Will merge once the CI finishes. |
antonfirsov
approved these changes
Jul 14, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #72095 to release/7.0-preview7
/cc @rzikm
Customer Impact
This PR utilizes the new HttpProtocolException (#70684) to report HTTP/3 protocol errors. This brings consistency in how HTTP/2 and HTTP/3 protocol errors are exposed to the user.
Testing
There are existing
System.Net.Httpfunctional tests and new tests were added.Risk
Low. HTTP/3 is in preview and not enabled by default.