Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing out required keyword #72233

Closed
wants to merge 1 commit into from

Conversation

ericstj
Copy link
Member

@ericstj ericstj commented Jul 15, 2022

no review please, this is just to test some arcade changes

@ericstj ericstj added NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it labels Jul 15, 2022
@ericstj ericstj requested a review from ManickaP July 15, 2022 00:02
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jul 15, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

no review please, this is just to test some arcade changes

Author: ericstj
Assignees: -
Labels:

NO-MERGE, NO-REVIEW, area-System.Net, new-api-needs-documentation

Milestone: -

@ericstj
Copy link
Member Author

ericstj commented Jul 15, 2022

Closing this since as it's given me the test coverage I wanted. Builds are successful across all platforms.

@ericstj ericstj closed this Jul 15, 2022
@karelz karelz added this to the 7.0.0 milestone Jul 19, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net new-api-needs-documentation NO-MERGE The PR is not ready for merge yet (see discussion for detailed reasons) NO-REVIEW Experimental/testing PR, do NOT review it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants