Add UnscopedRefAttribute
#72499
Merged
Add UnscopedRefAttribute
#72499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-system-runtime-compilerservices |
Sergio0694
reviewed
Jul 21, 2022
...libraries/System.Private.CoreLib/src/System/Diagnostics/CodeAnalysis/UnscopedRefAttribute.cs
Outdated
Show resolved
Hide resolved
…deAnalysis/UnscopedRefAttribute.cs Co-authored-by: Sergio Pedri <sergio0694@live.com>
Sergio0694
suggested changes
Jul 21, 2022
...libraries/System.Private.CoreLib/src/System/Diagnostics/CodeAnalysis/UnscopedRefAttribute.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Sergio Pedri <sergio0694@live.com>
stephentoub
reviewed
Jul 22, 2022
...libraries/System.Private.CoreLib/src/System/Diagnostics/CodeAnalysis/UnscopedRefAttribute.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jul 22, 2022
stephentoub
reviewed
Jul 22, 2022
...libraries/System.Private.CoreLib/src/System/Diagnostics/CodeAnalysis/UnscopedRefAttribute.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jul 22, 2022
stephentoub
reviewed
Jul 22, 2022
| AttributeTargets.Method | AttributeTargets.Property | AttributeTargets.Parameter, | ||
| AllowMultiple = false, | ||
| Inherited = false)] | ||
| public sealed class UnscopedRefAttribute : Attribute |
There was a problem hiding this comment.
We can hold off on doing so until it's needed, but we may need to do the same visibility dance we do with other attributes that may get compiled into other projects downlevel, e.g.
cston
approved these changes
Jul 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72074
/cc @jaredpar @cston