Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid AsyncLocal read in Activity.set_Current when CurrentChanged isn't handled #72621

Merged
merged 1 commit into from
Jul 21, 2022
Merged

Avoid AsyncLocal read in Activity.set_Current when CurrentChanged isn't handled #72621

merged 1 commit into from
Jul 21, 2022

Conversation

stephentoub
Copy link
Member

@ghost ghost assigned stephentoub Jul 21, 2022
@ghost
Copy link

ghost commented Jul 21, 2022

Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti
See info in area-owners.md if you want to be subscribed.

Issue Details

Should fix dotnet/perf-autofiling-issues#5202.

cc: @EgorBo, @tarekgh, @noahfalk

Author: stephentoub
Assignees: -
Labels:

area-System.Diagnostics.Tracing
Milestone: -

@EgorBo
Copy link
Member

EgorBo commented Jul 21, 2022

😄 that was fast

@stephentoub
Copy link
Member Author

Method Toolchain idFormat Mean Ratio
ActivityAllocations \main\corerun.exe Hierarchical 338.3 ns 1.00
ActivityAllocations \pr\corerun.exe Hierarchical 312.3 ns 0.93

@tarekgh
Copy link
Member

tarekgh commented Jul 21, 2022

Thanks @stephentoub

@stephentoub stephentoub merged commit bac2229 into dotnet:main Jul 21, 2022
@stephentoub stephentoub deleted the setcurrentread branch July 21, 2022 20:38
@ghost ghost locked as resolved and limited conversation to collaborators Aug 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tarekgh tarekgh tarekgh approved these changes

Assignees

@stephentoub stephentoub

Labels
area-System.Diagnostics.Tracing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Perf] Changes at 4/13/2022 8:35:34 PM
3 participants
@stephentoub @EgorBo @tarekgh