Correct nullable annotation on ICustomTypeDescriptor.GetConverter #72629
Conversation
The documentation, and even some of our own code, return null for this method. Correcting the nullable annotation to indicate that null can be returned. Fix dotnet#69229
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/area-system-componentmodel Issue DetailsThe documentation, and even some of our own code, return null for this method. Correcting the nullable annotation to indicate that null can be returned. Fix #69229 (Note it is probably best to review with whitespace changes ignored, since I moved one type out a level.)
|
src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/TypeDescriptor.cs
Show resolved
Hide resolved
|
Improvements: dotnet/perf-autofiling-issues#6852 |
I had suspected that this change would help perf, but I didn't want to jinx it. 😄 |
|
Also seeing wins on Arm64: dotnet/perf-autofiling-issues#6861 dotnet/perf-autofiling-issues#6867 |
ghost
locked as resolved and limited conversation to collaborators
The documentation, and even some of our own code, return null for this method. Correcting the nullable annotation to indicate that null can be returned.
Fix #69229
(Note it is probably best to review with whitespace changes ignored, since I moved one type out a level.)