Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUIC] Return connection dispose in H3loopback connection #72713

Merged
merged 2 commits into from
Jul 24, 2022

Conversation

ManickaP
Copy link
Member

Fixes #57779

Seems like everything is working as it should. We do have WaitForClientDisconnectAsync as part of H3Loopback connection shutdown.

@ghost
Copy link

ghost commented Jul 23, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #57779

Seems like everything is working as it should. We do have WaitForClientDisconnectAsync as part of H3Loopback connection shutdown.

Author: ManickaP
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@ManickaP ManickaP changed the title [QUIC] Return connection dipose in H3loopback connection [QUIC] Return connection dispose in H3loopback connection Jul 23, 2022
@ManickaP
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ManickaP
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ManickaP
Copy link
Member Author

Failures unrelated.

@ManickaP ManickaP merged commit 93f0512 into dotnet:main Jul 24, 2022
@ManickaP ManickaP deleted the mapichov/quic-57779 branch July 24, 2022 12:39
@karelz karelz added this to the 7.0.0 milestone Aug 7, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[HTTP/3] Loopback server should dispose underlying QUIC connection
3 participants