Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: Clone all local addresses when importing dup #72714

Merged
merged 1 commit into from
Aug 29, 2022

Commits on Jul 23, 2022

  1. JIT: Clone all local addresses when importing dup

    Roslyn emits `dup` for the field address when compound assignment
    operators are used on struct fields. We would previously spill this
    address leading us to mark such structs as address exposed and disabling
    promotion.
    
    Also allow removing unnecessary casts in cases like
    ```
    ASG
      LCL_FLD ubyte V00
      CAST int <- ubyte <- int
        ...
    ```
    
    we only allowed this cast removal for LCL_VAR and IND before, which led
    to unnecessary new casts in some cases with this change.
    jakobbotsch committed Jul 23, 2022
    Configuration menu
    Copy the full SHA
    0527c5b View commit details
    Browse the repository at this point in the history