Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TryAddWithoutValidation ViaHeaderValue #72741

Merged
merged 2 commits into from
Jul 25, 2022
Merged

TryAddWithoutValidation ViaHeaderValue #72741

merged 2 commits into from
Jul 25, 2022

Conversation

feiyun0112
Copy link
Contributor

fix #72677

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jul 24, 2022
@ghost
Copy link

ghost commented Jul 24, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

fix #72677

Author: feiyun0112
Assignees: -
Labels:

area-System.Net.Http
Milestone: -

MihaZupan
MihaZupan approved these changes Jul 24, 2022
View reviewed changes
Copy link
Member

@MihaZupan MihaZupan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

src/libraries/System.Net.Http/src/System/Net/Http/Headers/ViaHeaderValue.cs Outdated Show resolved Hide resolved
@MihaZupan MihaZupan added this to the 7.0.0 milestone Jul 24, 2022
@MihaZupan
Copy link
Member

The test failure is #72586

@MihaZupan MihaZupan merged commit dfd6efc into dotnet:main Jul 25, 2022
@runfoapp runfoapp bot mentioned this pull request Jul 26, 2022
Closed
@feiyun0112 feiyun0112 deleted the fix-72677 branch July 26, 2022 08:21
@runfoapp runfoapp bot mentioned this pull request Jul 27, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MihaZupan MihaZupan MihaZupan approved these changes

Assignees
No one assigned
Labels
area-System.Net.Http community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

ViaHeaderValue throws on TryParse
2 participants
@feiyun0112 @MihaZupan