Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/7.0-preview7] Remove npm audit call in CI #72813

Merged
merged 1 commit into from
Jul 26, 2022
Merged

[release/7.0-preview7] Remove npm audit call in CI #72813

merged 1 commit into from
Jul 26, 2022

Conversation

radical
Copy link
Member

@radical radical commented Jul 25, 2022 •
edited
Loading

Backport from main.
(cherry picked from commit f7cba48)

@lewing @radical
Remove npm audit call in CI (dotnet#72386)
3ee67f8 
Backport from `main`.
(cherry picked from commit f7cba48)
@radical radical requested a review from carlossanlop July 25, 2022 21:37
@radical radical requested a review from lewing as a code owner July 25, 2022 21:37
@ghost ghost assigned radical Jul 25, 2022
@radical radical changed the title [release/7.0-preview7] Mark JsonSerializerOptions.TypeInfoResolver as… [release/7.0-preview7] Remove npm audit call in CI Jul 25, 2022
@radical
Copy link
Member Author

radical commented Jul 25, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member Author

radical commented Jul 25, 2022

All the wasm jobs got built successfully, and are running tests now.

@carlossanlop
Copy link
Member

Installer build failure is unrelated.

.packages\microsoft.dotnet.arcade.sdk\7.0.0-beta.22358.3\tools\VSTest.targets(55,5): error MSB3491: (NETCORE_ENGINEERING_TELEMETRY=Build) 
Could not write lines to file "D:\a\_work\1\s\artifacts\log\Release\AppHost.Bundle.Tests_net7.0_x64.log".
The process cannot access the file 'D:\a\_work\1\s\artifacts\log\Release\AppHost.Bundle.Tests_net7.0_x64.log' because it is 
being used by another process.

@carlossanlop
Copy link
Member

carlossanlop commented Jul 26, 2022 •
edited
Loading

@radical @lewing the wasm tests timed out, but it seems there were also some failures. Are they related to this change?

@radical
Copy link
Member Author

radical commented Jul 26, 2022

@radical @lewing the wasm tests timed out, but it seems there were also some failures. Are they related to this change?

They can be ignored. This PR fixes the build, and that passed for all the jobs.

@carlossanlop carlossanlop merged commit eecb028 into dotnet:release/7.0-preview7 Jul 26, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmitche mmitche mmitche approved these changes

@carlossanlop carlossanlop carlossanlop approved these changes

@lewing lewing lewing approved these changes

Assignees

@radical radical

Labels
area-Build-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@radical @carlossanlop @lewing @mmitche