Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hardcode /tmp in named pipe tests, it's not for us on Android #73067

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

directhex
Copy link
Contributor

Closes: #49873

@ghost
Copy link

ghost commented Jul 29, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Closes: #49873

Author: directhex
Assignees: -
Labels:

area-System.IO

Milestone: -

@directhex directhex added this to the 7.0.0 milestone Jul 29, 2022
Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It seems we hit cases years ago where TMPDIR on macOS was very long so the named pipe failed, if that's the case then I'd just special case this for Android.

@directhex
Copy link
Contributor Author

The OSX tests have passed. Is there some test beyond what's in the libs tests for this TMPDIR issue?

@jozkee
Copy link
Member

jozkee commented Jul 29, 2022

Is this other one not an issue for Android?

string name = Path.Combine("/tmp", PipeStreamConformanceTests.GetUniquePipeName());

@directhex
Copy link
Contributor Author

Is this other one not an issue for Android?

string name = Path.Combine("/tmp", PipeStreamConformanceTests.GetUniquePipeName());

Nope.

<ItemGroup Condition="'$(TargetPlatformIdentifier)' == 'windows'">

@stephentoub stephentoub merged commit cfe26ec into dotnet:main Aug 1, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.IO.Pipes test failures on Android
5 participants