[wasm] deprecate legacy JS API and propose new #73068

pavelsavara · 2022-07-29T15:52:33Z

Added new API methods to top level next to MONO and BINDING namespaces
- runMain, runMainAndExit, setEnvironmentVariable, getAssemblyExports are just renamed existing API
- getConfig will return mono-config.json type MonoConfig
- setHeapI64Big, setHeapI32 , getHeapI32, ... memory functions
marked MONO and BINDING namespaces obsolete
separated legacy API into dotnet-legacy.d.ts
renamed snake_case to camelCase names
- the idea is that these types were mostly added to Net7 and we have still chance to fix it without backward compatibility shim.
- The shim could be done, if really necessary.

Details

in the mono-config.json/MonoConfigtype
- assembly_root -> assemblyRootFolder
- debug_level -> debugLevel
- enable_debugging - removed in favor of debugLevel
- isError - removed, we throw exceptions as necessary
- globalization_mode -> globalizationMode
- diagnostic_tracing -> diagnosticTracing
- remote_sources -> remoteSources
- environment_variables -> environmentVariables
- runtime_options -> runtimeOptions
- aot_profiler_options -> aotProfilerOptions with writeAt & sendTo
- coverage_profiler_options -> coverageProfilerOptions with writeAt & sendTo
- diagnostic_options -> diagnosticOptions
- ignore_pdb_load_errors -> ignorePdbLoadErrors
- wait_for_debugger -> waitForDebugger
in AssetEntry
- virtual_path -> virtualPath
- load_remote -> loadRemote
- is_optional -> isOptional
- we are producing it in src\tasks\WasmAppBuilder\WasmAppBuilder.cs
in DiagnosticServerOptions
- connect_url -> connectUrl
in UnnamedProviderConfiguration
- keyword_mask -> keywordMask
in Diagnostics
- EventLevel -> eventLevel
updated samples and templates
renamed runtime arg --diagnostic_tracing -> --diagnostic-tracing
replaced IMPORTS with setModuleImports
renamed runtimeBuildInfo & productVersion & buildConfiguration to first lowercase

ghost · 2022-07-29T15:52:52Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

separated legacy API into dotnet-legacy.d.ts
renamed snake_case to camelCase names in the mono-config.json type MonoConfig
- the idea is that this type/file was added to Net7 and we have still chance to fix it without backward compatibility shim. The shim could be done, if truly necessary.
- assembly_root -> assemblyRootFolder
- debug_level -> debugLevel
- enable_debugging - removed in favor of debugLevel
- isError - removed, we throw exceptions as necessary
- globalization_mode -> globalizationMode
- diagnostic_tracing -> diagnosticTracing
- remote_sources -> remoteSources
- environment_variables -> environmentVariables
- runtime_options -> runtimeOptions
- aot_profiler_options -> aotProfilerOptions with writeAt & sendTo
- coverage_profiler_options -> coverageProfilerOptions with writeAt & sendTo
- diagnostic_options -> diagnosticOptions
- ignore_pdb_load_errors -> ignorePdbLoadErrors
- wait_for_debugger -> waitForDebugger
renamed snake_case to camelCase names in DiagnosticServerOptions
- virtual_path -> virtualPath
- load_remote -> loadRemote
- is_optional -> isOptional
- we are producing it in src\tasks\WasmAppBuilder\WasmAppBuilder.cs
renamed snake_case to camelCase names in AssetEntry
- connect_url -> connectUrl
renamed snake_case to camelCase names in UnnamedProviderConfiguration
- keyword_mask -> keywordMask
renamed names in Diagnostics
- EventLevel -> eventLevel
Added new API next to MONO and BINDING namespaces
- runMain, runMainAndExit, setEnvironmentVariable, getAssemblyExports are just renamed existing API
- getConfig will return mono-config.json type MonoConfig
- applyConfig, or merge-in MonoConfig via shalow merge
marked MONO and BINDING namespaces obsolete
updated samples and templates

Author:	pavelsavara
Assignees:	pavelsavara
Labels:	`arch-wasm`, `area-System.Runtime.InteropServices.JavaScript`
Milestone:	7.0.0

pavelsavara · 2022-08-01T19:03:58Z

/azp run runtime-wasm

azure-pipelines · 2022-08-01T19:04:12Z

Azure Pipelines successfully started running 1 pipeline(s).

src/mono/sample/wasm/browser-profile/main.js

src/mono/sample/wasm/browser/main.js

src/mono/wasm/debugger/tests/debugger-test/wasm-page-without-assets.html

src/mono/wasm/runtime/export-api.ts

src/mono/wasm/runtime/modularize-dotnet.md

# Conflicts: # src/mono/wasm/runtime/dotnet.d.ts # src/mono/wasm/runtime/startup.ts # src/mono/wasm/runtime/types.ts

pavelsavara · 2022-08-02T13:11:06Z

/azp run runtime-wasm

azure-pipelines · 2022-08-02T13:11:16Z

Azure Pipelines successfully started running 1 pipeline(s).

maraf

I think we could remove EXPORTS and IMPORTS. I like the API for getting assembly exports (getAssemblyExports) and as imports are similar feature, we could provide a similar API for it, eg. setAssemblyImports(assembly: string, imports: any).
With this API we can remove EXPORTS and IMPORTS.

I'm still not sure if flatten API object is the right choice. I know than by now we have only few functions, but it seems to me that adding more structure is good for future enhancements.

# Conflicts: # src/mono/wasm/runtime/cwraps.ts # src/mono/wasm/runtime/exports.ts # src/mono/wasm/runtime/startup.ts

pavelsavara · 2022-08-03T10:00:39Z

/azp run runtime-wasm

azure-pipelines · 2022-08-03T10:00:48Z

Azure Pipelines successfully started running 1 pipeline(s).

maraf · 2022-08-03T10:30:59Z

After a discussion we have chosen a 100% flat API in root object returned from the createDotnetRuntime.

src/mono/wasm/runtime/es6/dotnet.es6.lib.js

src/mono/wasm/runtime/es6/dotnet.es6.pre.js

pavelsavara · 2022-08-03T10:49:32Z

/azp run runtime-wasm

azure-pipelines · 2022-08-03T10:49:43Z

Azure Pipelines successfully started running 1 pipeline(s).

src/mono/sample/wasm/browser/main.js

src/mono/wasm/runtime/types.ts

pavelsavara · 2022-08-03T13:48:54Z

/azp run runtime-wasm

azure-pipelines · 2022-08-03T13:49:07Z

Azure Pipelines successfully started running 1 pipeline(s).

Issue: dotnet#73312

Issue: dotnet#71887

pavelsavara · 2022-08-03T20:06:59Z

/azp run runtime-wasm

azure-pipelines · 2022-08-03T20:07:09Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2022-08-03T22:48:13Z

/azp run runtime-wasm

azure-pipelines · 2022-08-03T22:48:23Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2022-08-04T06:01:19Z

System.NotSupportedException : The deserialization constructor for type 'System.Tuple1[System.Int32]' contains parameters with null names.` is #73347

Debugger failures are #73342

wip

547403e

pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript labels Jul 29, 2022

pavelsavara added this to the 7.0.0 milestone Jul 29, 2022

pavelsavara self-assigned this Jul 29, 2022

pavelsavara requested review from lambdageek, maraf and kg July 29, 2022 15:53

wip

5bb0b60

pavelsavara marked this pull request as ready for review August 1, 2022 19:06

pavelsavara requested review from radical, lewing, thaystg and marek-safar as code owners August 1, 2022 19:06

maraf reviewed Aug 2, 2022

View reviewed changes

pavelsavara added 3 commits August 2, 2022 13:28

Merge branch 'main' into wasm_js_api

c78b5ca

feedback

b3ac5e3

Merge branch 'main' into wasm_js_api

4312a71

# Conflicts: # src/mono/wasm/runtime/dotnet.d.ts # src/mono/wasm/runtime/startup.ts # src/mono/wasm/runtime/types.ts

pavelsavara requested a review from maraf August 2, 2022 13:11

maraf approved these changes Aug 2, 2022

View reviewed changes

maraf self-requested a review August 2, 2022 18:10

maraf requested changes Aug 2, 2022

View reviewed changes

ghost added the needs-author-action An issue or pull request that requires more info or actions from the author. label Aug 2, 2022

pavelsavara added 2 commits August 2, 2022 21:15

Merge branch 'main' into wasm_js_api

70de988

# Conflicts: # src/mono/wasm/runtime/cwraps.ts # src/mono/wasm/runtime/exports.ts # src/mono/wasm/runtime/startup.ts

feedback

0ff99ad

maraf reviewed Aug 3, 2022

View reviewed changes

src/mono/wasm/runtime/es6/dotnet.es6.lib.js Outdated Show resolved Hide resolved

src/mono/wasm/runtime/es6/dotnet.es6.pre.js Outdated Show resolved Hide resolved

feedback

258add7

maraf approved these changes Aug 3, 2022

View reviewed changes

ilonatommy approved these changes Aug 3, 2022

View reviewed changes

src/mono/sample/wasm/browser/main.js Show resolved Hide resolved

src/mono/wasm/runtime/types.ts Show resolved Hide resolved

feedback

aea46b9

feedback: diagnosticOptions will become env variable

1cb7c1d

lambdageek approved these changes Aug 3, 2022

View reviewed changes

radical and others added 4 commits August 3, 2022 18:08

[wasm] Fix Wasm.Build.Tests builds

b26c856

Issue: dotnet#73312

[wasm] Disable failing Wasm.Build.Tests test on windows

b487be6

Issue: dotnet#71887

Merge branch 'main' into wasm_js_api

88db278

Merge branch 'wbt-green' into wasm_js_api

b8e2098

pavelsavara added 2 commits August 4, 2022 00:14

Merge branch 'main' into wasm_js_api

472ae40

fix template

9b95921

pavelsavara changed the title ~~[wip][wasm] deprecate legacy JS API and propose new~~ [wasm] deprecate legacy JS API and propose new Aug 4, 2022

pavelsavara merged commit 0d80733 into dotnet:main Aug 4, 2022

ghost locked as resolved and limited conversation to collaborators Sep 3, 2022

pavelsavara deleted the wasm_js_api branch November 29, 2022 16:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wasm] deprecate legacy JS API and propose new #73068

[wasm] deprecate legacy JS API and propose new #73068

pavelsavara commented Jul 29, 2022 •

edited

Loading

ghost commented Jul 29, 2022

pavelsavara commented Aug 1, 2022

azure-pipelines bot commented Aug 1, 2022

pavelsavara commented Aug 2, 2022

azure-pipelines bot commented Aug 2, 2022

maraf left a comment •

edited

Loading

pavelsavara commented Aug 3, 2022

azure-pipelines bot commented Aug 3, 2022

maraf commented Aug 3, 2022

pavelsavara commented Aug 3, 2022

azure-pipelines bot commented Aug 3, 2022

pavelsavara commented Aug 3, 2022

azure-pipelines bot commented Aug 3, 2022

pavelsavara commented Aug 3, 2022

azure-pipelines bot commented Aug 3, 2022

pavelsavara commented Aug 3, 2022

azure-pipelines bot commented Aug 3, 2022

pavelsavara commented Aug 4, 2022

[wasm] deprecate legacy JS API and propose new #73068

[wasm] deprecate legacy JS API and propose new #73068

Conversation

pavelsavara commented Jul 29, 2022 • edited Loading

Details

ghost commented Jul 29, 2022

pavelsavara commented Aug 1, 2022

azure-pipelines bot commented Aug 1, 2022

pavelsavara commented Aug 2, 2022

azure-pipelines bot commented Aug 2, 2022

maraf left a comment • edited Loading

Choose a reason for hiding this comment

pavelsavara commented Aug 3, 2022

azure-pipelines bot commented Aug 3, 2022

maraf commented Aug 3, 2022

pavelsavara commented Aug 3, 2022

azure-pipelines bot commented Aug 3, 2022

pavelsavara commented Aug 3, 2022

azure-pipelines bot commented Aug 3, 2022

pavelsavara commented Aug 3, 2022

azure-pipelines bot commented Aug 3, 2022

pavelsavara commented Aug 3, 2022

azure-pipelines bot commented Aug 3, 2022

pavelsavara commented Aug 4, 2022

pavelsavara commented Jul 29, 2022 •

edited

Loading

maraf left a comment •

edited

Loading