Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support InfiniteTimeSpan in Select #73204

Merged
merged 4 commits into from
Aug 12, 2022
Merged

support InfiniteTimeSpan in Select #73204

merged 4 commits into from
Aug 12, 2022

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Aug 2, 2022

This change adds special handling for Timeout.InfiniteTimeSpan so it can be passed to Select without throwing.
fixes #72458

@wfurt wfurt added this to the 7.0.0 milestone Aug 2, 2022
@wfurt wfurt self-assigned this Aug 2, 2022
@ghost
Copy link

ghost commented Aug 2, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

This change adds special handling for Timeout.InfiniteTimeSpan so it can be passed to Select without throwing.
fixes #72458

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Sockets

Milestone: 7.0.0

@wfurt wfurt requested a review from ManickaP August 11, 2022 15:59
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Co-authored-by: Marie Píchová <11718369+ManickaP@users.noreply.github.com>
@wfurt wfurt merged commit afc9675 into dotnet:main Aug 12, 2022
@wfurt wfurt deleted the InfiniteTimeSpan branch August 12, 2022 18:42
@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Socket.Select TimeSpan-based overload is broken for Timeout.InfiniteTimeSpan
3 participants