-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend detection for unsupported types #73241
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis Issue DetailsMakes a couple of changes on unsupported types:
|
krwq
reviewed
Aug 2, 2022
src/libraries/System.Text.Json/src/System/Text/Json/ThrowHelper.Serialization.cs
Show resolved
Hide resolved
eiriktsarpalis
commented
Aug 2, 2022
eiriktsarpalis
commented
Aug 2, 2022
eiriktsarpalis
commented
Aug 2, 2022
src/libraries/System.Text.Json/src/System/Text/Json/ThrowHelper.Serialization.cs
Show resolved
Hide resolved
krwq
reviewed
Aug 2, 2022
krwq
approved these changes
Aug 2, 2022
* Add runtime detection for constructor parameters with missing names. Fix dotnet#58690. * Extend NotSupportedTypeConverter to MemberInfo types from System.Type types. Contributes to dotnet#58947.
fe9e787
to
583a3a4
Compare
eerhardt
reviewed
Aug 3, 2022
src/libraries/System.Text.Json/src/System/Text/Json/ThrowHelper.Serialization.cs
Show resolved
Hide resolved
This was referenced Aug 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes a couple of changes on unsupported types:
UnsupportedTypeConverter
fromType
toMemberInfo
types, which prevent the serializer from accidentally attempting to serialize anyMethodInfo
instances, which was the root cause of STJ failing ungracefully when attempting to serialize attributes #58947.