Fix Configuration.Binder to bind to IList<T> properties #73267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binding to an IList<T> in ConfigurationBinder was failing because we were only checking for ICollection<T>. The fix is to also check for IList<T>. Fix dotnet#73221
ghost
assigned 
|
Tagging subscribers to this area: @dotnet/area-extensions-configuration Issue DetailsBinding to an IList in ConfigurationBinder was failing because we were only checking for ICollection. The fix is to also check for IList. Fix #73221 cc @SteveDunn
|
eerhardt
commented
Aug 2, 2022
| @@ -282,33 +282,6 @@ private void GetIntDictionaryT<T>(T k1, T k2, T k3) | |||
| Assert.Equal("val_2", options[k3]); | |||
| } | |||
|
|
|||
| [Fact] | |||
There was a problem hiding this comment.
These two tests are 100% duplicates with the BindXXX tests directly below them. No reason to have duplicate tests.
There was a problem hiding this comment.
Thanks for fixing so quickly
tarekgh
approved these changes
Aug 2, 2022
SteveDunn
approved these changes
Aug 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Binding to an IList in ConfigurationBinder was failing because we were only checking for ICollection. The fix is to also check for IList.
Fix #73221
cc @SteveDunn