Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify initialization of CILJit singleton #73471

Merged
merged 2 commits into from
Aug 5, 2022
Merged

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Aug 5, 2022

No description provided.

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 5, 2022
@ghost ghost assigned jkotas Aug 5, 2022
@ghost
Copy link

ghost commented Aug 5, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: jkotas
Assignees: -
Labels:

area-CodeGen-coreclr

Milestone: -

Copy link
Member

@jakobbotsch jakobbotsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided CI is green

@jkotas
Copy link
Member Author

jkotas commented Aug 5, 2022

System.Net.WebSockets.Client.Tests crashed on Libraries Test Run checked coreclr Linux_musl x64 Debug. Stacktrace:

Call Site
libcoreclr!Object::GetGCSafeMethodTable [/__w/1/s/src/coreclr/vm/object.h @ 446] 
libcoreclr!Object::ValidateInner+0x1b0
libcoreclr!Object::Validate+0x8a [/__w/1/s/src/coreclr/vm/object.cpp @ 1124] 
libcoreclr!OBJECTREF::OBJECTREF+0xfa [/__w/1/s/src/coreclr/vm/object.cpp @ 1124] 
libcoreclr!ObjectFromHandle+0x2c [/__w/1/s/src/coreclr/vm/gchandleutilities.h @ 44] 
libcoreclr!MarshalNative::GCHandleInternalGet+0x50

Tracked by #69125

@jkotas jkotas merged commit a231aa7 into dotnet:main Aug 5, 2022
@jkotas jkotas deleted the simpler-fix branch August 5, 2022 23:00
@ghost ghost locked as resolved and limited conversation to collaborators Sep 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants