Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullable annotations on IEquatable/IComparable constraints #73495

Merged
merged 2 commits into from
Aug 8, 2022

Conversation

stephentoub
Copy link
Member

Fixes #73457

@stephentoub stephentoub added this to the 7.0.0 milestone Aug 5, 2022
@dotnet-issue-labeler
Copy link

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Aug 5, 2022

Tagging subscribers to this area: @dotnet/area-system-memory
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes #73457

Author: stephentoub
Assignees: -
Labels:

area-System.Memory

Milestone: 7.0.0

If the first two values are non-null and don't match the input and the third value is null, it gets dereferenced and results in a null reference exception.
@stephentoub
Copy link
Member Author

This actually found a pre-existing bug. This:

Console.WriteLine(new[] { "1", "2", "3" }.AsSpan().LastIndexOfAny("4", "5", null));

fails with:

Unhandled exception. System.NullReferenceException: Object reference not set to an instance of an object.
   at System.SpanHelpers.LastIndexOfAny[T](T& searchSpace, T value0, T value1, T value2, Int32 length)

I've fixed it as well in the second commit.

@stephentoub
Copy link
Member Author

Failure is #73247

Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @stephentoub !

@stephentoub stephentoub merged commit 38b9d05 into dotnet:main Aug 8, 2022
@stephentoub stephentoub deleted the equatablenullable branch August 8, 2022 10:34
@ghost ghost locked as resolved and limited conversation to collaborators Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect nullable annotations on most MemoryExtensions methods
2 participants