Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Describe PGO kind in JitDisasm #73529

Merged
merged 2 commits into from
Aug 7, 2022
Merged

Describe PGO kind in JitDisasm #73529

merged 2 commits into from
Aug 7, 2022

Conversation

EgorBo
Copy link
Member

@EgorBo EgorBo commented Aug 7, 2022

@AndyAyersMS you asked to leave a mark in JitDisasm whether PGO is Static or Dynamic. With this PR it's now:

; Assembly listing for method Program:Foo(Program):int
; Emitting BLENDED_CODE for X64 CPU with AVX - Windows
; Tier-1 compilation
; optimized code
; optimized using profile data
; rsp based frame
; partially interruptible
; with Dynamic PGO: edge weights are valid, and fgCalledCount is 50
; 0 inlinees with PGO data; 1 single block inlinees; 0 inlinees without PGO data

... asm

And since JitDisasm will be available in Release this is how users will be able to diagnose whether Dynamic PGO was kicked in or not

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 7, 2022
@ghost ghost assigned EgorBo Aug 7, 2022
@ghost
Copy link

ghost commented Aug 7, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

@AndyAyersMS you asked to leave a mark in JitDisasm whether PGO is Static or Dynamic. With this PR it's now:

; Assembly listing for method Program:Foo(Program):int
; Emitting BLENDED_CODE for X64 CPU with AVX - Windows
; Tier-1 compilation
; optimized code
; optimized using profile data
; rsp based frame
; partially interruptible
; with Dynamic PGO: edge weights are valid, and fgCalledCount is 50
; 0 inlinees with PGO data; 1 single block inlinees; 0 inlinees without PGO data

... asm

And since JitDisasm will be available in Release this is how users will be able to diagnose whether Dynamic PGO was kicked in or not

Author: EgorBo
Assignees: EgorBo
Labels:

area-CodeGen-coreclr
Milestone: -

@EgorBo @jakobbotsch
Update src/coreclr/jit/codegencommon.cpp
7146842 
Co-authored-by: Jakob Botsch Nielsen <Jakob.botsch.nielsen@gmail.com>
@EgorBo
Copy link
Member Author

EgorBo commented Aug 7, 2022

CI failure is unrelated (#73247)

AndyAyersMS
AndyAyersMS approved these changes Aug 7, 2022
View reviewed changes
Copy link
Member

@AndyAyersMS AndyAyersMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. For end users, relying on this still might be a challenge, if there's no easy access to the process stdout.

@EgorBo EgorBo merged commit ed07799 into dotnet:main Aug 7, 2022
This was referenced Aug 8, 2022
Closed
Closed
@AndyAyersMS
Copy link
Member

Also see #72056 which added support in ETW.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndyAyersMS AndyAyersMS AndyAyersMS approved these changes

@jakobbotsch jakobbotsch jakobbotsch approved these changes

Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EgorBo @AndyAyersMS @jakobbotsch