[PERF] Fix "x$PERF_PREREQS_INSTALLED was unexpected at this time" Error for Microbenchmarks #73584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and for running on windows machines.
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsFix "x$PERF_PREREQS_INSTALLED was unexpected at this time" Error for Microbenchmarks from changes in #72431. This splits the changed command between a Windows and non-Windows version as Windows does not support Bash if statements.
|
…e double bracket is not necessary.
radical
reviewed
Aug 8, 2022
radical
approved these changes
Aug 8, 2022
|
/azp run runtime-wasm-perf |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I have a test runtime perf run of this here: https://dev.azure.com/dnceng/internal/_build/results?buildId=1930401. It looks like we should be good to merge this. |
|
The changes are perf pipeline specific, and the remaining builds are completely unrelated. I'm merging this to unblock the pipeline. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix "x$PERF_PREREQS_INSTALLED was unexpected at this time" Error for Microbenchmarks from changes in #72431. This splits the changed command between a Windows and non-Windows version as Windows does not support Bash if statements.