Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vectorize {Last}IndexOf{Any} and {Last}IndexOfAnyExcept without code duplication #73768

Merged
merged 37 commits into from
Aug 17, 2022
Merged

Vectorize {Last}IndexOf{Any} and {Last}IndexOfAnyExcept without code duplication #73768

merged 37 commits into from
Aug 17, 2022

Commits on Aug 11, 2022

  1. Vectorize LastIndexOf

    @adamsitnik
    adamsitnik committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    9d01665 View commit details
    Browse the repository at this point in the history

  2. use structs to get performant code without code duplication

    @adamsitnik
    adamsitnik committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    14224a3 View commit details
    Browse the repository at this point in the history

  3. use it in all possible places

    @adamsitnik
    adamsitnik committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    d05cf56 View commit details
    Browse the repository at this point in the history

  4. vectorize LastIndexOfAny(value0, value1)

    @adamsitnik
    adamsitnik committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    22f71ff View commit details
    Browse the repository at this point in the history

  5. vectorize LastIndexOfAnyExcept(value0, value1)

    @adamsitnik
    adamsitnik committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    bbc64e0 View commit details
    Browse the repository at this point in the history

  6. simplify it to make it easier to add 3 and 4 values overloads

    @adamsitnik
    adamsitnik committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    f265d28 View commit details
    Browse the repository at this point in the history

  7. vectorize LastIndexOfAny and LastIndexOfAnyExcept for 3 values

    @adamsitnik
    adamsitnik committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    b0f259c View commit details
    Browse the repository at this point in the history

  8. rename (I am not convinced it's the best name yet)

    @adamsitnik
    adamsitnik committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    7dc03c3 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2022

  1. vectorize Contains

    @adamsitnik
    adamsitnik committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    628d429 View commit details
    Browse the repository at this point in the history

  2. hide the implementation details

    @adamsitnik
    adamsitnik committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    114ca88 View commit details
    Browse the repository at this point in the history

  3. address review from Jan, don't cast Span to ROS. Introduce new helper… 

    … and avoid duplication by calling it from both Span and ROS
    @adamsitnik
    adamsitnik committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    95a1b62 View commit details
    Browse the repository at this point in the history

  4. vectorize IndexOf(value)

    @adamsitnik
    adamsitnik committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    ab8df3d View commit details
    Browse the repository at this point in the history

  5. rename IndexOf used only by strlen to IndexOfNullByte and optimize it… 

    … to searching for zeros
    @adamsitnik
    adamsitnik committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    bb13957 View commit details
    Browse the repository at this point in the history

  6. vectorize IndexOfAny<T>(value0, value1) and IndexOfAnyExcept<T>(value… 

    …0, value1)
    @adamsitnik
    adamsitnik committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    bbb7e4c View commit details
    Browse the repository at this point in the history

  7. vectorize IndexOfAny<T>(value0, value1, value2) and IndexOfAnyExcept<… 

    …T>(value0, value1, value2)
    @adamsitnik
    adamsitnik committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    9186b8f View commit details
    Browse the repository at this point in the history

  8. vectorize IndexOfAny<T>(value0, value1, value2, value3) and IndexOfAn… 

    …yExcept<T>(value0, value1, value2, value3)
    @adamsitnik
    adamsitnik committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    5a39d21 View commit details
    Browse the repository at this point in the history

  9. vectorize IndexOfAny<T>(value0, value1, value2, value3, value4)

    @adamsitnik
    adamsitnik committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    9099ef9 View commit details
    Browse the repository at this point in the history

  10. remove dead code

    @adamsitnik
    adamsitnik committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    5661793 View commit details
    Browse the repository at this point in the history

  11. use built-in helpers

    @adamsitnik
    adamsitnik committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    8cb8208 View commit details
    Browse the repository at this point in the history

  12. Revert "address review from Jan, don't cast Span to ROS. Introduce ne… 

    …w helper and avoid duplication by calling it from both Span and ROS"

This reverts commit 95a1b62.

# Conflicts:
#	src/libraries/System.Private.CoreLib/src/System/MemoryExtensions.cs
    @adamsitnik
    adamsitnik committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    ec447c7 View commit details
    Browse the repository at this point in the history

  13. add/remove special handling of some types

    @adamsitnik
    adamsitnik committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    62f16c1 View commit details
    Browse the repository at this point in the history

  14. fix NativeAOT build

    @adamsitnik
    adamsitnik committed Aug 12, 2022
    Configuration menu
    Copy the full SHA
    26c188d View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2022

  1. address code review feedback

    @adamsitnik
    adamsitnik committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    2af01e3 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2022

  1. perform manual loop unrolling in order to avoid perf regression for s… 

    …mall inputs

use INumber instead of IEquatable to generate better codegen when comparing multiple values
    @adamsitnik
    adamsitnik committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    b305c54 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into vectorizeLastIndexOf 

    # Conflicts:
#	src/libraries/System.Private.CoreLib/src/System/SpanHelpers.Char.cs
    @adamsitnik
    adamsitnik committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    f954ac5 View commit details
    Browse the repository at this point in the history

  3. restore Vector<T> code path as Vector128 is not accelerated by Mono x… 

    …64 (it is on arm64)
    @adamsitnik
    adamsitnik committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    846e4fc View commit details
    Browse the repository at this point in the history

  4. remove redundant for loop that was left here by mistake

    @adamsitnik
    adamsitnik committed Aug 14, 2022
    Configuration menu
    Copy the full SHA
    8a74f28 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2022

  1. apply manual loop unrolling to LastIndexOfAny methods

    @adamsitnik
    adamsitnik committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    fab3143 View commit details
    Browse the repository at this point in the history

  2. vectorize LastIndexOf(4) and LastIndexOfAnyExcept(4)

    @adamsitnik
    adamsitnik committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    4274f54 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Jan Kotas <jkotas@microsoft.com>
    @adamsitnik @jkotas
    adamsitnik and jkotas committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    59c867f View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'upstream/main' into vectorizeLastIndexOf

    @adamsitnik
    adamsitnik committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    3049470 View commit details
    Browse the repository at this point in the history

  5. fix the build

    @adamsitnik
    adamsitnik committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    afc09bd View commit details
    Browse the repository at this point in the history

  6. fix the NativeAOT build

    @adamsitnik
    adamsitnik committed Aug 15, 2022
    Configuration menu
    Copy the full SHA
    efdff0e View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. Merge remote-tracking branch 'upstream/main' into vectorizeLastIndexOf 

    # Conflicts:
#	src/libraries/System.Private.CoreLib/src/System/MemoryExtensions.cs
#	src/libraries/System.Private.CoreLib/src/System/SpanHelpers.T.cs
    @adamsitnik
    adamsitnik committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    5831e09 View commit details
    Browse the repository at this point in the history

  2. optimize Except methods for small inputs

    @adamsitnik
    adamsitnik committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    7f003da View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2022

  1. address code review feedback: 

    - add a failing test and fix the bug
- remove comments
- rename generic arguments to follow existing convention
- rename constant to start with uppercase character
    @adamsitnik
    adamsitnik committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    0dc257f View commit details
    Browse the repository at this point in the history

  2. reduce the regression for IndexOfAnyExcept(3) and LastIndexOfAnyExcep… 

    …t(3) for small inputs by always calling the heavily optimized SpanHelpers.IndexOfAnyExceptValueType
    @adamsitnik
    adamsitnik committed Aug 17, 2022
    Configuration menu
    Copy the full SHA
    0c6b01d View commit details
    Browse the repository at this point in the history