Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ManifestMsiVersion to CreateVisualStudioWorkload call #73877

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Add ManifestMsiVersion to CreateVisualStudioWorkload call #73877

merged 1 commit into from
Aug 12, 2022

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Aug 12, 2022

No description provided.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned hoyosjs Aug 12, 2022
@hoyosjs
Copy link
Member Author

hoyosjs commented Aug 12, 2022

cc: @danmoseley @jeffschwMSFT

jeffschwMSFT
jeffschwMSFT approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

cc @carlossanlop

@marcpopMSFT marcpopMSFT mentioned this pull request Aug 12, 2022
Closed
@carlossanlop carlossanlop merged commit 7ff0afb into release/6.0 Aug 12, 2022
@carlossanlop carlossanlop deleted the juhoyosa/set-ManifestMsiVersion branch August 12, 2022 23:56
@ghost ghost locked as resolved and limited conversation to collaborators Sep 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeffschwMSFT jeffschwMSFT jeffschwMSFT approved these changes

@carlossanlop carlossanlop carlossanlop approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@joeloff joeloff Awaiting requested review from joeloff

Assignees

@hoyosjs hoyosjs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoyosjs @carlossanlop @jeffschwMSFT