Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0-rc1] [wasm] Reduce allocation when options are passed to fetch #74230

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 19, 2022

Backport of #74142 to release/7.0-rc1

/cc @maraf

Customer Impact

Reduce allocation of List<T> when passing options to fetch.

Testing

Unit tests.

Risk

None.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

@ghost
Copy link

ghost commented Aug 19, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #74142 to release/7.0-rc1

/cc @maraf

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@maraf maraf added the arch-wasm WebAssembly architecture label Aug 19, 2022
@ghost
Copy link

ghost commented Aug 19, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #74142 to release/7.0-rc1

/cc @maraf

Customer Impact

Reduce allocation of List<T> when passing options to fetch.

Testing

Unit tests.

Risk

None.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Author: github-actions[bot]
Assignees: -
Labels:

arch-wasm, area-System.Net.Http

Milestone: -

@carlossanlop
Copy link
Member

@marek-safar @lewing @pavelsavara need an area owner sign off and someone to approve the backport.

@carlossanlop
Copy link
Member

Approved, signed-off and CI passed. Ready to merge.

@carlossanlop carlossanlop merged commit 55594df into release/7.0-rc1 Aug 22, 2022
@carlossanlop carlossanlop deleted the backport/pr-74142-to-release/7.0-rc1 branch August 22, 2022 15:32
@karelz karelz added this to the 7.0.0 milestone Aug 23, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Net.Http
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants