Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wasm timestamp test by adding 10M tolerance #74317

Merged
merged 2 commits into from
Aug 22, 2022
Merged

fix wasm timestamp test by adding 10M tolerance #74317

merged 2 commits into from
Aug 22, 2022

Conversation

danmoseley
Copy link
Member

Fix #48717

@danmoseley danmoseley added arch-wasm WebAssembly architecture area-System.IO labels Aug 21, 2022
@ghost
Copy link

ghost commented Aug 21, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #48717

Author: danmoseley
Assignees: -
Labels:

arch-wasm, area-System.IO
Milestone: -

@ghost ghost assigned danmoseley Aug 21, 2022
@danmoseley danmoseley changed the title fix wasm timestamp fix wasm timestamp test by adding 10M tolerance Aug 21, 2022
@ghost
Copy link

ghost commented Aug 21, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #48717

Author: danmoseley
Assignees: -
Labels:

arch-wasm, area-System.IO
Milestone: -

carlossanlop
carlossanlop approved these changes Aug 21, 2022
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good.

I'd feel more comfortable merging this is we get confirmation from the wasm area owners that the 10m tolerance is expected from browsers, and not a problem on our side. The question was asked in the issue but never answered.

@lewing @radical any concerns about this?

lewing
lewing approved these changes Aug 22, 2022
View reviewed changes
Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable enough

@danmoseley
Copy link
Member Author

Failure is #29683

@danmoseley danmoseley merged commit 12b4415 into dotnet:main Aug 22, 2022
@danmoseley danmoseley deleted the fixwasmtime2 branch August 22, 2022 02:18
@ghost ghost locked as resolved and limited conversation to collaborators Sep 21, 2022
@carlossanlop
Copy link
Member

/backport to release/7.0

@github-actions github-actions bot unlocked this conversation Jan 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3849314147

@carlossanlop
Copy link
Member

I saw this failure in this PR: #78830

@github-actions github-actions bot mentioned this pull request Jan 5, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carlossanlop carlossanlop carlossanlop approved these changes

@lewing lewing lewing approved these changes

Assignees

@danmoseley danmoseley

Labels
arch-wasm WebAssembly architecture area-System.IO
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CopyToNanosecondsPresent_LowTempRes
3 participants
@danmoseley @carlossanlop @lewing