Add Fedora 38 RID #74372
Add Fedora 38 RID #74372
Conversation
Fedora 38 is now in development:
$ podman run -it registry.fedoraproject.org/fedora:rawhide
[root@d3934d2b267b /]# cat /etc/os-release
NAME="Fedora Linux"
VERSION="38 (Container Image Prerelease)"
ID=fedora
VERSION_ID=38
VERSION_CODENAME=""
PLATFORM_ID="platform:f38"
PRETTY_NAME="Fedora Linux 38 (Container Image Prerelease)"
ANSI_COLOR="0;38;2;60;110;180"
LOGO=fedora-logo-icon
CPE_NAME="cpe:/o:fedoraproject:fedora:38"
DEFAULT_HOSTNAME="fedora"
HOME_URL="https://fedoraproject.org/"
DOCUMENTATION_URL="https://docs.fedoraproject.org/en-US/fedora/rawhide/system-administrators-guide/"
SUPPORT_URL="https://ask.fedoraproject.org/"
BUG_REPORT_URL="https://bugzilla.redhat.com/"
REDHAT_BUGZILLA_PRODUCT="Fedora"
REDHAT_BUGZILLA_PRODUCT_VERSION=rawhide
REDHAT_SUPPORT_PRODUCT="Fedora"
REDHAT_SUPPORT_PRODUCT_VERSION=rawhide
VARIANT="Container Image"
VARIANT_ID=container
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsFedora 38 is now in development: The changes to runtime.compatibility.json and runtime.json were automated and made by
|
|
@ViktorHofer @wfurt do we allow merging RIDs for distro versions under development? |
|
Yes we do. |
|
I did not find anything on Fedora pages (maybe I did not look enough) but it already has 38 here: https://en.wikipedia.org/wiki/Fedora_Linux_release_history |
|
I don't think we still need to keep adding these. source-build doesn't need them. dotnet/designs#260 describes why these rids are in fact not that useful. |
|
AFAIK this statement still applies which make the RID changes necessary: #57832 (comment) Please correct me if I'm wrong but I don't think that dotnet/designs#260 is yet committed. |
In most cases the rid doesn't need to be in the graph. This includes portable builds, source-build .NET, and distros for which the fallback applies (like Fedora). If dotnet/runtime build fails because the fallback is not right, then the
This design no longer requires non-portable rids to be in the rid graph. It does so because it considers cross-distro publishing not a supported use-case. If we're adding it here, it's because we consider that a supported use-case. I hope we can come to a lean rid graph in .NET 8. We've been adding these rids to make sure things build. That should no longer be necessary. |
At least as of 6.0, this patch is needed in source-build for the build to work. Here's a build log from the failing build: AFAIK, adding things to the RID graph for 6.0 (but not 7.0 or main) is not an option, so I have done PRs to add RIDs everywhere. |
|
@omajid does .NET 6 source-build on Fedora 38 work when you export |
Tested that in the RPM build. It seems to work for a bit then fails with other errors: https://kojipkgs.fedoraproject.org//work/tasks/8083/91188083/build.log
source-build runs a separate |
Thanks for giving it a try. Clearly this is not working... There are two rids we care about: We should be able to treat this latter rid as just a name. This name gets passed in from source-build as the From the log: issue #1: The target rid we should be passing here is issue #2: This location should be using This is why |
|
The 2nd issue should be fixed by #74498. |
This was replaced by #74504. With that PR, I can build .NET 6 packages on an unknown flavor of Fedora by setting What's still missing is the built runtime is not aware of the distro's rid. It needs to know the rid to be able to fall back to |
|
Can we merge this PR? The |
ghost
locked as resolved and limited conversation to collaborators
Fedora 38 is now in development:
The changes to runtime.compatibility.json and runtime.json were automated and made by
dotnet pack -p:UpdateRuntimeFiles=true