-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/7.0-rc1] Improve DOTNET_JitDisasm and introduce DOTNET_JitDisasmSummary #74392
[release/7.0-rc1] Improve DOTNET_JitDisasm and introduce DOTNET_JitDisasmSummary #74392
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsBackport of #74090 to .NET 7.0 rc1 on @stephentoub's request. This PR improves UX of a recently added feature to .NET 7.0 - Namely, this PR improves wildcard support (e.g.
Example of its output:
(btw, in this specific example Customer ImpactNo impact, JitDisasm and JitDisasmSummary are new configuration knobs in .NET7.0 TestingTested locally and by SuperPMI jobs RiskLow
|
It doesn't do any disasm. |
@EgorBo should this get DO-NOT-MERGE label due to #74090 (comment)? |
Good point, I assume it was just for consistency with JitDisasm because it was mainly introduced for that. |
I am double checking, but unless this is unblocking us from shipping RC1, I think we should port this fix to release/7 (for RC2). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved for rc1.
Approved/signed off. |
Backport of #74090 to .NET 7.0 rc1 on @stephentoub's request.
This PR improves UX of a recently added feature to .NET 7.0 -
DOTNET_JitDisasm=method
(#73365) which gives users ability to print rich assembly code for any function.Namely, this PR improves wildcard support (e.g.
DOTNET_JitDisasm=*foo*
orDOTNET_JitDisasm=MyType:*foo*()
) and, what is more important, introducesDOTNET_JitDisasmSummary=1
command to print all functions JIT compiles with a short summary (which tier, does it use PGO, etc) - it serves two purposes:Example of its output:
(btw, in this specific example
SubStringCountTest:Foo
is compiled 3 times (3 tiers basically))Customer Impact
No impact, JitDisasm and JitDisasmSummary are new configuration knobs in .NET7.0
Testing
Tested locally and by SuperPMI jobs
Risk
Low