Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/7.0] Use BOOL (vs. bool) in event pipe qcall signatures #74481

Merged
merged 1 commit into from
Aug 24, 2022

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #74389 to release/7.0

/cc @VSadov

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

@carlossanlop
Copy link
Member

Approved and signed off.
CI is green.
Ready to merge. :shipit:

@carlossanlop carlossanlop merged commit 949340c into release/7.0 Aug 24, 2022
@carlossanlop carlossanlop deleted the backport/pr-74389-to-release/7.0 branch August 24, 2022 15:39
@VSadov
Copy link
Member

VSadov commented Aug 24, 2022

Thanks!!

@nr-ahemsath
Copy link

Can somebody confirm if this made it into .NET 7 RC1? I'm testing with it ( 7.0.100-rc.1.22431.12 specifically) and I'm still seeing an exception very similar to the one described in issue #62145, which this is meant to fix.

@jeffschwMSFT
Copy link
Member

This will be in RC2

@vuqtran88
Copy link

Hello,
I was able to test this with a vanilla Asp.Net Core application and the fix worked in .NET 7 RC2. Any plan to fix this issue in .NET 6 ?

@ghost ghost locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants