Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Test, and app host fixes #74512

Merged
merged 3 commits into from
Aug 25, 2022
Merged

[wasm] Test, and app host fixes #74512

merged 3 commits into from
Aug 25, 2022

Conversation

radical
Copy link
Member

@radical radical commented Aug 24, 2022

  • Use explicity allowed ports with playwright, on linux too
  • Quote path, and arguments for wasm app host, to fix running with app host on windows

Fixes #72436 .

@ghost ghost assigned radical Aug 24, 2022
@ghost
Copy link

ghost commented Aug 24, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Use explicity allowed ports with playwright, on linux too
  • Quote path, and arguments for wasm app host, to fix running with app host on windows

Fixes #72436 .

Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono, test-failure
Milestone: -

@radical radical merged commit e8583df into dotnet:main Aug 25, 2022
@radical radical deleted the misc-fixes branch August 25, 2022 00:50
@thaystg
Copy link
Member

thaystg commented Sep 8, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2022

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3017570269

@github-actions github-actions bot mentioned this pull request Sep 8, 2022
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lewing lewing lewing approved these changes

@pavelsavara pavelsavara Awaiting requested review from pavelsavara

@thaystg thaystg Awaiting requested review from thaystg

Assignees

@radical radical

Labels
arch-wasm WebAssembly architecture area-Build-mono test-failure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[wasm][wbt] - Microsoft.Playwright.PlaywrightException : net::ERR_UNSAFE_PORT
3 participants
@radical @thaystg @lewing