Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for analyzing PR failures #74615

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Aug 25, 2022

Document the recent engineering system improvements

@ghost
Copy link

ghost commented Aug 25, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

Document the recent engineering system improvements

Author: jkotas
Assignees: -
Labels:

area-Meta

Milestone: -

@jkotas
Copy link
Member Author

jkotas commented Aug 25, 2022

cc @dotnet/runtime-infrastructure

Document the recent engineering system improvements
@danmoseley
Copy link
Member

cc @markwilkie

@tommcdon
Copy link
Member

cc @hoyosjs

@jkotas jkotas merged commit 2ac87a9 into dotnet:main Aug 26, 2022
@jkotas jkotas deleted the analyzing-failures branch August 26, 2022 02:54
@ViktorHofer
Copy link
Member

ViktorHofer commented Aug 26, 2022

FYI @danmoseley (EDIT: saw your comment too late).

@markwilkie
Copy link
Member

Thanks all!

@danmoseley
Copy link
Member

I actually didn't know about this known errors format/system. How can we increase awareness? @ViktorHofer maybe including in your next SDK update mail (not sure when that is)?

@markwilkie
Copy link
Member

There's been some talk too of "advertising" in a PR comment. Is this something folks are interested in? (we've been slow to do this kind of thing so we're not SPAMmy)

@ViktorHofer
Copy link
Member

@ViktorHofer maybe including in your next SDK update mail (not sure when that is)?

cc @jkoritzinsky @joperezr whoI believe will update the SDK in arcade and runtime soon.

@danmoseley
Copy link
Member

There's been some talk too of "advertising" in a PR comment. Is this something folks are interested in? (we've been slow to do this kind of thing so we're not SPAMmy)

Can you do that only for PR's that were merged on red? If so, seems like something worth a trial. "This PR was merged with one or more failing pipelines, but it is not linked to any known failures. Our goal is for all PR's merged with failures to be linked to a known failure. Please see foo.md for information about how to create and link known failures." or something better ?

@jkotas
Copy link
Member Author

jkotas commented Aug 29, 2022

I actually didn't know about this known errors format/system. How can we increase awareness?

FWIW, this was mentioned in "DevWF Team is Addressing YOUR Feedback Update!" email sent to everybody on 8/11, and a several other similar emails before that.

@markwilkie
Copy link
Member

Can you do that only for PR's that were merged on red?

We could. Would devs go back and actually look at it? @tommcdon mentioned too the possibility of advertising the build analysis tab for each failed PR. (this obviously has the create known issue link too)

Again....not sure what folks want.

@danmoseley
Copy link
Member

They would see the notification, either for their PR or someone else's. It would be an experiment for a temporary period, and if it was a problem we'd stop it.
We were recently discussing posting info about pipeline costs when a particularly expensive PR is merged, so it seems reasonable to try

@hoyosjs
Copy link
Member

hoyosjs commented Aug 29, 2022

There was an issue with this recently and the test log search will be rolling out. After that a how we work talk could be a good forum for this.

@ghost ghost locked as resolved and limited conversation to collaborators Sep 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants