-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for analyzing PR failures #74615
Conversation
Tagging subscribers to this area: @dotnet/area-meta Issue DetailsDocument the recent engineering system improvements
|
4ff14d6
to
bc3be6c
Compare
cc @dotnet/runtime-infrastructure |
Document the recent engineering system improvements
bc3be6c
to
f6b1d68
Compare
cc @markwilkie |
cc @hoyosjs |
FYI @danmoseley (EDIT: saw your comment too late). |
Thanks all! |
I actually didn't know about this known errors format/system. How can we increase awareness? @ViktorHofer maybe including in your next SDK update mail (not sure when that is)? |
There's been some talk too of "advertising" in a PR comment. Is this something folks are interested in? (we've been slow to do this kind of thing so we're not SPAMmy) |
cc @jkoritzinsky @joperezr whoI believe will update the SDK in arcade and runtime soon. |
Can you do that only for PR's that were merged on red? If so, seems like something worth a trial. "This PR was merged with one or more failing pipelines, but it is not linked to any known failures. Our goal is for all PR's merged with failures to be linked to a known failure. Please see foo.md for information about how to create and link known failures." or something better ? |
FWIW, this was mentioned in "DevWF Team is Addressing YOUR Feedback Update!" email sent to everybody on 8/11, and a several other similar emails before that. |
We could. Would devs go back and actually look at it? @tommcdon mentioned too the possibility of advertising the build analysis tab for each failed PR. (this obviously has the create known issue link too) Again....not sure what folks want. |
They would see the notification, either for their PR or someone else's. It would be an experiment for a temporary period, and if it was a problem we'd stop it. |
There was an issue with this recently and the test log search will be rolling out. After that a how we work talk could be a good forum for this. |
Document the recent engineering system improvements