Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[MONO] Move marshal-ilgen into a component (#71203)" #74674

Merged
merged 1 commit into from
Aug 27, 2022
Merged

Revert "[MONO] Move marshal-ilgen into a component (#71203)" #74674

merged 1 commit into from
Aug 27, 2022

Conversation

lambdageek
Copy link
Member

This reverts commit de32c44.

@ghost ghost assigned lambdageek Aug 26, 2022
@SamMonoRT SamMonoRT requested a review from naricc August 26, 2022 19:13
@lewing
Copy link
Member

lewing commented Aug 26, 2022

do you want to open a backport or target rc1 directly here?

@lambdageek
Copy link
Member Author

I started a separate revert for rc1: #74675

@lambdageek lambdageek mentioned this pull request Aug 26, 2022
Merged
carlossanlop
carlossanlop approved these changes Aug 27, 2022
View reviewed changes
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already merged the RC1 PR, so merging this one too. CI failures seem unrelated.

@carlossanlop carlossanlop merged commit 6c3c234 into dotnet:main Aug 27, 2022
@SamMonoRT SamMonoRT mentioned this pull request Sep 9, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@naricc naricc naricc approved these changes

@carlossanlop carlossanlop carlossanlop approved these changes

@radical radical Awaiting requested review from radical

@lewing lewing Awaiting requested review from lewing lewing is a code owner

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

@vargaz vargaz Awaiting requested review from vargaz

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

@lambdageek lambdageek

Labels
area-VM-meta-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lambdageek @lewing @carlossanlop @naricc