Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Fix JSExport on struct and records #74763

Merged
merged 11 commits into from
Aug 31, 2022
Merged

[wasm] Fix JSExport on struct and records #74763

merged 11 commits into from
Aug 31, 2022

Conversation

maraf
Copy link
Member

@maraf maraf commented Aug 29, 2022 •
edited
Loading

  • Fix generating qualified name for JSExport on structs, record classes and record structs.
  • Fix using expression bodied methods for JSExport.
  • Add unit test using all these variants with and without namespace and nested types.
  • Rewrite concatenating method name.

@maraf maraf self-assigned this Aug 29, 2022
@maraf maraf added this to the 8.0.0 milestone Aug 29, 2022
@ghost
Copy link

ghost commented Aug 29, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Fix generating qualified name for JSExports on structs, record classes and record strucs.
  • Add unit test using all these variants.
Author: maraf
Assignees: maraf
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: -

@maraf
Copy link
Member Author

maraf commented Aug 29, 2022

/azp run runtime-wasm

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maraf maraf marked this pull request as draft August 29, 2022 16:59
@maraf maraf marked this pull request as ready for review August 29, 2022 17:58
radical
radical approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@radical radical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comments, LGTM 👍

@maraf maraf merged commit 7922d61 into dotnet:main Aug 31, 2022
@maraf
Copy link
Member Author

maraf commented Aug 31, 2022

/backport to release/7.0

@github-actions
Copy link
Contributor

Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/2966642862

@github-actions github-actions bot mentioned this pull request Aug 31, 2022
Merged
@maraf maraf deleted the WasmFixJsExportStruct branch September 2, 2022 08:20
@ghost ghost locked as resolved and limited conversation to collaborators Oct 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@radical radical radical approved these changes

@pavelsavara pavelsavara pavelsavara approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@maraf maraf

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@maraf @radical @pavelsavara